Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for encoding/deconding Properties as String #1158

Merged
merged 3 commits into from
Oct 28, 2020

Conversation

daniel-jasinski
Copy link
Contributor

Implementation for issue 1152

@daniel-jasinski
Copy link
Contributor Author

@sandwwraith please take a look at this proposal for implementation.

Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR! I think we can merge this after all the comments are addressed

Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@daniel-jasinski
Copy link
Contributor Author

Added changes according to the comments/suggestions. Please have a look.

@sandwwraith sandwwraith merged commit f08c62f into Kotlin:dev Oct 28, 2020
@sandwwraith
Copy link
Member

Note that it does not close #1152 because it takes Map<String, String>, not a whole single String

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants