Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildClassSerialDescriptor does not create nullable descriptor #1929

Closed
sandwwraith opened this issue May 6, 2022 · 0 comments
Closed

buildClassSerialDescriptor does not create nullable descriptor #1929

sandwwraith opened this issue May 6, 2022 · 0 comments
Labels

Comments

@sandwwraith
Copy link
Member

Originally reported as https://youtrack.jetbrains.com/issue/KT-52300

To Reproduce

val descriptor = buildClassSerialDescriptor("FooBar") {
    isNullable = true
}
assertTrue(descriptor.isNullable) // throws

Expected behavior

Either we should allow to create nullable descriptors via builder or remove nullable property from it, leaving only descriptor.nullable extension. The latter would always append ? to serial name.

Environment

  • Library version: 1.3.2
@sandwwraith sandwwraith added the bug label May 6, 2022
sandwwraith added a commit that referenced this issue Sep 22, 2022
because it wasn't working properly and better alternative exists.

Fixes #1929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant