Fixed NoSuchMethodError when parsing a JSON stream on Java 8 #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2326 An explicit cast is needed here due to an API change in Java 9, see #2218. In Java 8 and earlier, the `position(I)` method was final in `Buffer`, and returned a `Buffer`. In Java 9 and later, the method was opened, and `ByteFuffer` overrides it, returning a `ByteBuffer`. This causes a `NoSuchMethodError` when running a class, compiled with a newer Java version, on Java 8.
shanshin
force-pushed
the
java8-streams
branch
3 times, most recently
from
307fa88
to
39fe976
Compare
sandwwraith
requested changes
Jun 13, 2023
formats/json/jvmMain/src/kotlinx/serialization/json/internal/CharsetReader.kt
Show resolved
Hide resolved
sandwwraith
approved these changes
Jun 13, 2023
woainikk
pushed a commit
that referenced
this pull request
Jun 20, 2023
Fixes #2326 An explicit cast is needed here due to an API change in Java 9, see #2218. In Java 8 and earlier, the `position(I)` method was final in `Buffer`, and returned a `Buffer`. In Java 9 and later, the method was opened, and `ByteBuffer` overrides it, returning a `ByteBuffer`. This causes a `NoSuchMethodError` when running a class, compiled with a newer Java version, on Java 8.
JesusMcCloud
pushed a commit
to a-sit-plus/kotlinx.serialization
that referenced
this pull request
Jul 5, 2023
…2328) Fixes Kotlin#2326 An explicit cast is needed here due to an API change in Java 9, see Kotlin#2218. In Java 8 and earlier, the `position(I)` method was final in `Buffer`, and returned a `Buffer`. In Java 9 and later, the method was opened, and `ByteBuffer` overrides it, returning a `ByteBuffer`. This causes a `NoSuchMethodError` when running a class, compiled with a newer Java version, on Java 8.
My-Name-Is-Jeff
added a commit
to Skytils/SkytilsMod
that referenced
this pull request
Jan 31, 2024
My-Name-Is-Jeff
added a commit
to Skytils/SkytilsMod
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed NoSuchMethodError when parsing a JSON stream on Java 8
Fixes #2326
An explicit cast is needed here due to an API change in Java 9, see #2218.
In Java 8 and earlier, the
position(I)method was final inBuffer, and returned aBuffer.In Java 9 and later, the method was opened, and
ByteBufferoverrides it, returning aByteBuffer.This causes a
NoSuchMethodErrorwhen running a class, compiled with a newer Java version, on Java 8.