Skip to content

Commit

Permalink
Check against type_info.selectable_default_views before setting defau…
Browse files Browse the repository at this point in the history
…lt view. (#506)

Fixes #488
  • Loading branch information
sbabrass authored and disko committed Aug 29, 2016
1 parent 89d02e8 commit 6babe71
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion kotti/views/edit/default_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,14 @@ def _is_valid_view(self, view_name):

return self._get_view(view_name) is not None

def _is_valid_default_view(self, view_name):
"""Return True if a view with name view_name is a valid choice as
default view for context.
"""

return self._is_valid_view(view_name) and view_name in [
v[0] for v in self.context.type_info.selectable_default_views]

@view_config(name='default-view-selector',
renderer='kotti:templates/default-view-selector.pt')
def default_view_selector(self):
Expand Down Expand Up @@ -103,7 +111,7 @@ def set_default_view(self):
'success'
)
else:
if self._is_valid_view(view_name):
if self._is_valid_default_view(view_name):
self.context.default_view = view_name
self.request.session.flash(
_("Default view has been set."),
Expand Down

0 comments on commit 6babe71

Please sign in to comment.