Http not found view #462
Merged
Http not found view #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 29, 2015 00:26
`kotti.security.get_user`.
Fixes issues with tests failing with a dummy root context, which is not a kotti.resources.Node. * Declare `kotti.resources.Node` implements `pyrmaid.interfaces.ILocation` * Add a Template API `is_location(context)` * Use the `is_location` API in master/edit/view templates to switch. Context objects under test must implement ILocation.
|
@davidemoro @disko |
|
On 29 Sep 2015, at 3:25, Matt Russell wrote:
I've not used the `i18n.sh` script in this PR
Please just run it and include at least the updated .pot and .po files
in the PR.
|
|
@disko let me know if there's anything more I can do here |
|
@mgrbyte Sorry for getting back so late on this. Could you please rebase the branch, so that it can be merged? TIA! |
|
Great job, thanks a lot. Now add a line to (please append |
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@disko @davidemoro
First stab at implementing #459.
Since this is my first PR of substance, I expect there may be one or two things not quite to your liking.
It turned out to be more complex that I first thought, particularly getting browser doc-tests working)
Summary
kotti.security.get_userusesunauthenticated_useridto look up the user in the db.kotti.resources.Nodenow formally implementspyramid.interfaces.ILocation, which providesa clean way to test if a context can be used in templates,
kotti.templates.TemplateAPImethods (e.gurl) and especially in tests.Mock/stub objects used as placeholders for
contextmust implement ILocation.