Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Podman #779

Merged
merged 3 commits into from
May 2, 2024
Merged

Add support for Podman #779

merged 3 commits into from
May 2, 2024

Conversation

chrissawyerfan4
Copy link
Contributor

@chrissawyerfan4 chrissawyerfan4 commented Apr 13, 2024

This commit:

  • Specifies which registries it is intending to pull from in the Dockerfiles such that Podman can resolve the dependencies
  • Sets a name for the PHP container, such that the commands work when using exec -it linkace-php
  • Mentions in CONTRIBUTING.md that Podman works also
  • Updates the PHP version in CONTRIBUTING.md as I proposed just now in v1.14.0 #746 (comment), since we're touching that line anyway
    • We shouldn't forget to also update the website docs if you like this change

I've tested it by using podman system reset which removes all containers and images and such, and then running the commands from the contributing docs in this commit's state, only replacing the word "docker" with "podman" for each command

If this all works well, eventually I think we can also update the documentation in the website repository to mention that Podman seems to work as a drop-in solution even if Docker remains the reference so long as that's what you're developing with. The vibe I get from Podman is that it's less commercial or more in the open source spirit than Docker, which might appeal to those self-hosting LinkAce, besides minor technical/architectural differences where someone might prefer one over the other

Kovah and others added 2 commits February 20, 2024 13:08
- Specify registries in Dockerfiles such that Podman can resolve the dependencies
- Add a name for the PHP container, such that the commands work when using `exec -it linkace-php`
- Mention in CONTRIBUTING.md that Podman works also
- Update the PHP version in CONTRIBUTING.md as proposed in Kovah#746 (comment)
@chrissawyerfan4
Copy link
Contributor Author

Oops, I seem to have based this on the latest commit made in main rather than dev. (I made a new branch, reverted to a specified commit, so that this is not dependent on the changes I made for #776.) I guess that should be resolved, but GitHub likes to keep history even if you push -f so, while I can resolve it locally, I'm not sure if that would resolve it on GitHub. Probably I should rebase my commit on the dev branch's current head, right?

@Kovah
Copy link
Owner

Kovah commented Apr 30, 2024

That's a great fix, thank you very much! Didn't know that Podman needs the docker.io/library prefix for general containers.

Regarding the container name: I personally got rid of any container names for my projects as I find it easier to use docker compose exec [service name] (which I have a dce abbreviation for). I will update the dev docs to use that instead of docker exec instead.

@chrissawyerfan4
Copy link
Contributor Author

Didn't know that Podman needs the docker.io/library prefix for general containers.

I guess the idea is to be unbiased towards any vendor, but then it does ship with some aliases built-in it seems, so... 🤷 I'm just happy there is a syntax that works for both :)

I personally got rid of any container names for my projects [...]. I will update the dev docs to use that instead of docker exec instead.

Not sure if I enabled contributor edits for this pull request but, if I did, do you want to just get rid of that name line once the dev docs are updated and then hit merge?

@Kovah Kovah merged commit fc7081a into Kovah:dev May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants