Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weasyprint now included with print-css.rocks #1026

Closed
zopyx opened this issue Jan 11, 2020 · 5 comments
Closed

Weasyprint now included with print-css.rocks #1026

zopyx opened this issue Jan 11, 2020 · 5 comments
Milestone

Comments

@zopyx
Copy link

zopyx commented Jan 11, 2020

Just to let you now:

print-css.rocks now includes Weasyprint (currently without having checked and value the test results). But feel free to test the Weasysprint results compared to other tools.

@liZe
Copy link
Member

liZe commented Jan 25, 2020

Hello @zopyx,

Thanks a lot, that’s very useful!

I’ve launched the tests with WeasyPrint and compared the results with Prince. I’ve found unknown bugs in WeasyPrint that I’ll report (and some missing features that are already reported).

Can I send you a pull request with WeasyPrint’s results? I’ll probably change a couple of tests too, as some of them only use proprietary properties that WeasyPrint doesn’t understand.

@zopyx
Copy link
Author

zopyx commented Jan 25, 2020

Please send PR for HTML and CSS. I will recreate the PDFs with the latest weasyprint version

@zopyx
Copy link
Author

zopyx commented Feb 6, 2020

I updated print-css.rocks for Weasyprint after validating my "BASIC" tests...there are a few issues here

https://www.print-css.rocks/lessons

@liZe
Copy link
Member

liZe commented Feb 6, 2020

Here are the problems I’ve found for tests in the lessons folder:

Because of bugs in WeasyPrint

Because of problems in lessons stylesheets

Because of missing features

@liZe
Copy link
Member

liZe commented Apr 3, 2020

An issue has been open for each bug, it’s time to close this issue!

@liZe liZe closed this as completed Apr 3, 2020
@liZe liZe added this to the 52 milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants