Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support var() in shorthand and multiple-value functions #2017

Merged
merged 10 commits into from Jan 3, 2024
Merged

Conversation

liZe
Copy link
Member

@liZe liZe commented Dec 11, 2023

Fix #1219.

Possible improvement before merging: support var() in other functions.

Let’s forget for now: support other functions such as calc() (see #357.)

@liZe liZe added this to the 61.0 milestone Dec 11, 2023
@liZe
Copy link
Member Author

liZe commented Dec 11, 2023

OK, let’s focus on var in functions first, it’s already really complicated.

Who on hell allowed things like

--red: 100; --green: 80; --blue: 0; color: rgb(var(--red) var(--green) var(--blue))

or

--red-green: 100, 0; color: rgb(var(--red-green), 200)

in CSS?

@liZe
Copy link
Member Author

liZe commented Jan 1, 2024

Possible improvement before merging: support var() in other functions.

Done!

@liZe liZe marked this pull request as ready for review January 1, 2024 11:53
@liZe liZe merged commit f0824a2 into main Jan 3, 2024
12 checks passed
@liZe liZe deleted the functions branch January 3, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle var function in properties with multiple values
1 participant