Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #253.
This feature has been implemented in a clean way.
Random thoughts:
find_style_attributes
andfind_presetational_hints
is possible, it would avoid going through the whole tree twice.test.weasyprint.org
pass without a crash.check_style_attribute
with constant strings is probably useless.Comments are welcome, as usual. I won't merge it right now, I'd like (at least):