Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the :nth() page selector. #846

Merged
merged 21 commits into from Apr 10, 2019
Merged

Support the :nth() page selector. #846

merged 21 commits into from Apr 10, 2019

Commits on Aug 17, 2018

  1. Copy the full SHA
    4a6153f View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. Copy the full SHA
    857d889 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. Copy the full SHA
    84e1813 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    f1a6da7 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    f2e9784 View commit details
    Browse the repository at this point in the history
  4. Fix tests

    liZe committed Apr 1, 2019
    Copy the full SHA
    b497198 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Use empty string as default value of named page

    That's the value given in the spec, using None doesn't add anything and even
    introduces bugs.
    liZe committed Apr 2, 2019
    Copy the full SHA
    ed4f008 View commit details
    Browse the repository at this point in the history
  2. Minor fixes

    liZe committed Apr 2, 2019
    Copy the full SHA
    be6c46c View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    ce7e9dd View commit details
    Browse the repository at this point in the history
  4. Set nth() selector specificity

    liZe committed Apr 2, 2019
    Copy the full SHA
    4877518 View commit details
    Browse the repository at this point in the history
  5. Use explicit variable names

    liZe committed Apr 2, 2019
    Copy the full SHA
    1d0c3e4 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    36fa280 View commit details
    Browse the repository at this point in the history
  7. Simplify page style declaration

    liZe committed Apr 2, 2019
    Copy the full SHA
    3e953b4 View commit details
    Browse the repository at this point in the history
  8. Add page declarations on demand

    With the previous system, we were listing all page types as the cartesian
    product of page names and pseudo selectors. Declarations were added for all
    these possible page types.
    
    The nth() page selector makes this system impossible, as we can't make the
    cartesian product with a number of pages we don't know at the beginning of the
    rendering. We now add declarations before rendering each page, based on the
    properties of the page.
    
    This new way is faster when the total number of pages is lower than the
    cartesian product of possible pages. For long documents, we could improve speed
    by detecting CSS rules based on page index or page name, and use cached results
    for all pages that don't rely on such rules.
    liZe committed Apr 2, 2019
    Copy the full SHA
    fc7db27 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    7f1051b View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    cff70ee View commit details
    Browse the repository at this point in the history
  11. Add tests

    liZe committed Apr 2, 2019
    Copy the full SHA
    6724076 View commit details
    Browse the repository at this point in the history
  12. Handle :nth(An+B) notation

    liZe committed Apr 2, 2019
    Copy the full SHA
    d637212 View commit details
    Browse the repository at this point in the history
  13. Minor fixes in documentation

    liZe committed Apr 2, 2019
    Copy the full SHA
    1a65600 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    961a39c View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Copy the full SHA
    fbb1f13 View commit details
    Browse the repository at this point in the history