New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the :nth()
page selector.
#846
Merged
Commits on Aug 17, 2018
Commits on Jan 24, 2019
Commits on Apr 1, 2019
Commits on Apr 2, 2019
-
Use empty string as default value of named page
That's the value given in the spec, using None doesn't add anything and even introduces bugs.
-
-
-
-
-
-
-
Add page declarations on demand
With the previous system, we were listing all page types as the cartesian product of page names and pseudo selectors. Declarations were added for all these possible page types. The nth() page selector makes this system impossible, as we can't make the cartesian product with a number of pages we don't know at the beginning of the rendering. We now add declarations before rendering each page, based on the properties of the page. This new way is faster when the total number of pages is lower than the cartesian product of possible pages. For long documents, we could improve speed by detecting CSS rules based on page index or page name, and use cached results for all pages that don't rely on such rules.
-
-
-
-
-
Commits on Apr 3, 2019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.