Fixing to checks breaking rendering of DateTimeLine and TimeDeltaLine #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradoxxxzero
added a commit
that referenced
this pull request
Sep 28, 2015
Fixing to checks breaking rendering of DateTimeLine and TimeDeltaLine
|
Thanks for the fix. There are no test that tests the SVG integrally because it would break with every modification. You can however add a test that reproduce this problem and check that the line tag is in the svg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two checks for range of x and y values did not test for None. These values can also be zero and therefore the check evaluates to False, which then leads to empty rendered SVG and PNG graphs.
I could not find tests actually validating SVG graphs, so the current tests do not cover this. Feel free to point out, where this is and I update the tests.