Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Docker builds #115

Closed
akalipetis opened this issue Jun 5, 2018 · 6 comments
Closed

Automated Docker builds #115

akalipetis opened this issue Jun 5, 2018 · 6 comments

Comments

@akalipetis
Copy link
Contributor

I've seen that there is a separate repository for Docker builds (https://github.com/Kozea/docker-wdb-server) which is not updated regularly.

I created an automated build from my fork (https://github.com/akalipetis/wdb), configuring it to tag releases correctly, which should work as expected, though I believe that it would be best if it was under the correct namespace (kozea/wdb).

I have opened a new PR, which should make Docker builds reproducible and allow different versions to be built correctly, even at a later point in time.

The only thing needed is for someone having access to both this repository and the Docker Hub team to create a rule that:

  • Builds master as latest
  • Builds all tags as the name of the tag

There is extensive documentation about Docker automated builds here, but I'd be happy to help in any way I can.

@paradoxxxzero
Copy link
Member

Ok I configured the docker hub at kozea/wdb as you said.
Please report any misconfiguration and thanks for doing this.

@akalipetis
Copy link
Contributor Author

Seems like a typo slipped through, I'll open a follow up PR, sorry for the mess.

@paradoxxxzero
Copy link
Member

Ha that's why! No problem I'll merge it right after.

@diegodelemos
Copy link

Hello! is the automatic build working properly?

$ docker pull kozea/wdb-server
Using default tag: latest
latest: Pulling from kozea/wdb-server
cc1a78bfd46b: Already exists
6861473222a6: Pull complete
7e0b9c3b5ae0: Pull complete
3ec98735f56f: Pull complete
9b311b87a021: Pull complete
048165938570: Pull complete
1ca3d78efb22: Pull complete
0f6c8999c3b7: Pull complete
5a85410f5000: Pull complete
1bcb9151787d: Pull complete
Digest: sha256:50bccddab71c865e47088a6dbc27191c852288c4fc91fe2cb70799f928f6de3e
Status: Downloaded newer image for kozea/wdb-server:latest
$ docker run -ti --rm kozea/wdb-server bash
pip freezeroot@0256500a5efc:/# pip freeze | grep -i wdb
wdb==3.2.3
wdb.server==3.2.3

3.2.4 fixes a problem with websockets we are having with 3.2.3. I have tested docker build ./wdb/server --build-arg WDB_VERSION=3.2.4 -t kozea/wdb-server and it works perfectly. We could build it ourselves but we are spawning wdb in a cluster and we would like to directly pull the image (otherwise we would have to build and host it ourselves). Thanks and have a good weekend 🏄

@akalipetis
Copy link
Contributor Author

The correct image should be: kozea/wdb

@diegodelemos
Copy link

oops! thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants