Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples): add usage examples #24

Merged
merged 30 commits into from
Nov 29, 2023
Merged

feat(examples): add usage examples #24

merged 30 commits into from
Nov 29, 2023

Conversation

gaspermerela
Copy link
Contributor

Description

Created examples:

  • tracker of ETH and ERC20 token balances for a given address
  • abi generation and ERC20 transfer
  • data decoding: decoding tx data with SC wrapper or with function signature
  • consolidated and manual request batching
  • ETH to ERC20 swap with listening to UniswapV2Pair Sync event
  • Searching for transactions with function selector from SC wrapper or manually from the function signature

Solution

ArtificialPB
ArtificialPB requested changes Nov 26, 2023
View reviewed changes
Copy link
Member

@ArtificialPB ArtificialPB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. Looking good, just needs a few changes and simplifications.

Please follow the conventional commits naming for PR titles since we plan to auto-gen changelog from them.

examples/src/main/kotlin/io/ethers/examples/abi/TransferERC20.kt Outdated Show resolved Hide resolved
examples/src/main/kotlin/io/ethers/examples/abi/TransferERC20.kt Outdated Show resolved Hide resolved
examples/src/main/kotlin/io/ethers/examples/balancetracker/BalanceTracker.kt Outdated Show resolved Hide resolved
examples/src/main/kotlin/io/ethers/examples/balancetracker/BalanceTracker.kt Outdated Show resolved Hide resolved
examples/src/main/kotlin/io/ethers/examples/batchrequests/BatchRequests.kt Outdated Show resolved Hide resolved
examples/src/main/kotlin/io/ethers/examples/datadecoding/DataDecoding.kt Outdated Show resolved Hide resolved
...rc/main/kotlin/io/ethers/examples/tokenswapwitheventlistening/TokenSwapWithEventListening.kt Outdated Show resolved Hide resolved
...rc/main/kotlin/io/ethers/examples/tokenswapwitheventlistening/TokenSwapWithEventListening.kt Show resolved Hide resolved
@ArtificialPB ArtificialPB changed the title Examples/function selectors feat: add usage examples Nov 26, 2023
@gaspermerela gaspermerela changed the title feat: add usage examples feat(examples): add usage examples Nov 27, 2023
@gaspermerela
feat: initialise examples module
fac39b9
@gaspermerela
feat(examples): balance tracker using manual batching and ArgParser
a32adf8
@gaspermerela
fix(examples): balance tracker - ArgParser name change, make paramete…
9db6f20 
…r private
@gaspermerela
refactor(examples): balance tracker - added missing ERC20 Abi, use on…
c3af7b3 
…ly ws provider, simplification
@gaspermerela
refactor(examples): Converting examples project to submodule
eeed710
@gaspermerela
fix(examples): balance tracker - use batching, token list as parameter
6f3422d
@gaspermerela
feat(examples): abi generation - transfer ERC20 token
a0272de
@gaspermerela
refactor(examples): abi generation and transfer ERC20
0adc24e
@gaspermerela
fix(examples): transfer ERC20 - NIT
f1a46d7
@gaspermerela
fix(examples): transferERC20 - ERC20 import fix
b7a0554
@gaspermerela
feat(examples): decoding tx data when SC ABI is and is not known
a01a1a2
@gaspermerela
refactor(examples): Data decoding
2f28671
@gaspermerela
fix(examples): Data decoding - printing results simplification
e8ad572
@gaspermerela
refactor(examples): Data decoding - moved ABI to different folder
d6776c5
ArtificialPB
ArtificialPB requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@ArtificialPB ArtificialPB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two small changes and it's ready for merge

examples/src/main/kotlin/io/ethers/examples/datadecoding/DataDecoding.kt Outdated

// # Manually decode function input data when we only know function signature
val function = AbiFunction.parseSignature("swapExactTokensForTokens(uint256,uint256,address[],address,uint256)")
val manualDec = AbiCodec.decodeWithPrefix(4, function.inputs, calldata.value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be replaced with function.decodeCall. Normally, users should not use AbiCodec directly.

@ArtificialPB ArtificialPB merged commit c029150 into Kr1ptal:master Nov 29, 2023
1 check passed
@gaspermerela gaspermerela deleted the examples/function-selectors branch December 1, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialPB ArtificialPB ArtificialPB approved these changes

@kustrun kustrun Awaiting requested review from kustrun kustrun is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaspermerela @ArtificialPB