Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging and splitting beams, node point precision and vector utility functions #36

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

haavahk
Copy link
Contributor

@haavahk haavahk commented Feb 2, 2022

Changes are related to:

  • typing and type hints, tying to make code consistent using from __future__ import annotations.

Additions are related to:

  • merging beams
  • splitting beam into two beams
  • vector functions related to merging and splitting beams
  • rounding of point precision on node
  • safe adding/removing of objects to/from Node.refs

Copy link
Owner

@Krande Krande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after skimming through your PR and tested this locally and found that all tests are passing. I have no issues accepting this :)

Thanks a lot!

Best Regards
Kristoffer

@@ -1,3 +1,5 @@
from __future__ import annotations
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I did not know about this. I am all for removing the " from any typechecked references :)

@Krande Krande merged commit d986233 into Krande:dev Feb 3, 2022
@haavahk haavahk deleted the fetch_2_feb branch May 27, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants