Wcn36xx smd debug 1 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now callers are forced to use semicolon in the end. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Easier to follow what's wcn36xx is doing. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
If CONFIG_DYNAMIC_DEBUG is enabled user would need to use both debug_mask and /sys/kernel/debug/dynamic_debug/ to get debug logs. That's just confusing, it should be enough to use debug_mask module parameter. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Also introduce wcn36xx_warn() and use that to print the warning. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Also simplify wcn36xx_tx() in the process. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
And make the log messages more compact as well. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
This reverts commit 113f8ef. There's not concensus how to handle dynamic debugging, so revert this change until we find a good solution.
|
could you please rebase this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to cleanup and make debug logs more compact. Makes it easier to
debug issues that way.