wcn36xx: mako hal commands #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear with what firmware version we should use these. Just to keep things simple remove them. Also remove related unneeded unions from few structs. No functional changes. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Mako firmware interface (1.3.1.0) needs a bit different config sta command. To handle that, create struct wcn36xx_hal_config_sta_req_msg_v1 which is to be used with mako firmware. wcn36xx will dynamically detect from firmware API version if older (_v1) or newer version of the command structure needs to be used. I implemented it so that we always populate the new structure first and then if we detect that older structure is needed we just copy the values from the original structure to the v1 structure. That way structure needs to be populated only once. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Now I don't see any firmware errors with mako when connecting to an AP. And in AP mode I see beacons now. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
wcn36xx doesn't currently report tx frame status back to mac80211 so we should advertise the capability IEEE80211_HW_REPORTS_TX_ACK_STATUS either. Oddly enough this also fixes my first association always fails on mako problem: <6>[ 25.474622] Loading modules backported from Linux version next-20130412-0-gd39d88d <6>[ 25.474866] Backport generated by backports.git 805b01f <6>[ 25.609797] cfg80211: Calling CRDA to update world regulatory domain <4>[ 25.829665] wcn36xx: WARNING Failed to read macaddress file wlan/macaddr0, using a random address instead <6>[ 25.830306] wcn36xx: mac0: 00:a0:c6:4a:1a:ef <6>[ 25.840836] wcnss_wlan triggered by userspace <6>[ 25.925041] wcn36xx: firmware WLAN version 'WCN v2.0 IRIS v2.0 with 48MHz XO' and CRM version 'AAAAAANAAW122023' <6>[ 25.925164] wcn36xx: firmware API 1.3.1.0, 12 stations, 2 bssids <6>[ 25.928734] ADDRCONF(NETDEV_UP): wlan0: link is not ready <6>[ 28.041690] wlan0: authenticate with 00:03:7f:40:82:dd <6>[ 28.070929] wlan0: direct probe to 00:03:7f:40:82:dd (try 1/3) <6>[ 42.082862] adjust_soc: ibat_ua = -1000, vbat_uv = 4341018, soc = 100, batt_temp=323 Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
KrasnikovEugene
added a commit
that referenced
this pull request
May 22, 2013
wcn36xx: mako hal commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.