Remove firmware allocation from wcn struct #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the nv pointer from the wcn struct and keep it inside the smd_load_nv function as local. This way we don't keep it allocated throught the life of the module and won't waste memory. This commit also includes minor cleanup of unused variables in the smd_load_nv function. Signed-off-by: Olof Johansson <dev@skyshaper.net>
KrasnikovEugene
added a commit
that referenced
this pull request
Jul 12, 2013
Remove firmware allocation from wcn struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the nv pointer from the wcn struct and keep it inside the
smd_load_nv function as local. This way we don't keep it allocated
throught the life of the module and won't waste memory.
This commit also includes minor cleanup of unused variables in the
smd_load_nv function.
Signed-off-by: Olof Johansson dev@skyshaper.net