Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match on Substring Fails for Part Word #34

Closed
flywire opened this issue Nov 2, 2015 · 6 comments
Closed

Match on Substring Fails for Part Word #34

flywire opened this issue Nov 2, 2015 · 6 comments

Comments

@flywire
Copy link

flywire commented Nov 2, 2015

I have a match 'Pharmacy' but it fails for 'STAY HEALTHYPHARMACY'. Match should not be restricted to whole words.

@Kraymer
Copy link
Owner

Kraymer commented Nov 2, 2015

This is by design, restricting to whole words avoids a whole class of "false positive" problems.

eg you add a match "NEM" for category "RESTAURANT" to categorize this new vietnamese "House of nem" restaurant that just opened, and then you have all your transactions with "CINEMA" something as payee line that get categorized as "RESTAURANT".

In your case, you just need to add a HEALTHYPHARMACY match for Pharmacy category.

@flywire
Copy link
Author

flywire commented Nov 2, 2015

Another example: I have a match 'Hotel' but it fails for 'Super Hotels'. Maybe let the user have a switch.

@Kraymer
Copy link
Owner

Kraymer commented Nov 3, 2015

I'll try as much as possible to limit switches even if sometimes it mean having an opiniated tool.
But I hear you: re-entering close matches is too cumbersome. I won't automate the registering of partial matches right now for the reason aforementioned but I think it can be improve, see #35.

@Kraymer Kraymer closed this as completed Nov 3, 2015
@Kraymer
Copy link
Owner

Kraymer commented Dec 13, 2015

Part word match implemented by 0fdb1a5, see https://github.com/Kraymer/qifqif/wiki#advanced-matchings for more details

@flywire can you test the dev version from master branch ?

@flywire
Copy link
Author

flywire commented Jan 6, 2016

Sorry, hectic over Christmas.

I'll uninstall and reinstall. Then I'll have to check how to setup my test
environment again - my notes were not good enough.

flywire

On Mon, Dec 14, 2015 at 8:37 AM, Fabrice Laporte notifications@github.com
wrote:

Part word match implemented by 0fdb1a5
0fdb1a5,
see https://github.com/Kraymer/qifqif/wiki#advanced-matchings for more
details

@flywire https://github.com/flywire can you test the dev version from
master branch ?


Reply to this email directly or view it on GitHub
#34 (comment).

@Kraymer
Copy link
Owner

Kraymer commented Jan 6, 2016

@flywire since I wrote previous comment, a new release has been shipped. So you just have to pip uninstall and then reinstall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants