Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Line Spacing Bug in 'Keep my question' Mode with Windows EOLs #19

Closed
BernoulliBox opened this issue Jan 27, 2024 · 4 comments
Closed

Comments

@BernoulliBox
Copy link

I am a big fan of this plugin and use it a lot. I've noticed a niggling issue that I was hoping you could look at.

When the plugin is operated in 'Keep my question' mode and Notepad++ is configured to use the Windows line ending characters (CR-LF), the question text is inadvertently altered to include double line spacing. Interestingly, this issue does not manifest when the editor is set to use Linux EOLs, where the original text is maintained as expected.

Hopefully you'll find time to cover this at some point, as it would significantly enhance the user experience for those of us who rely on Windows EOLs in our workflows!

Thank you for your time and for the valuable work you've done on this plugin.

@Krazal
Copy link
Owner

Krazal commented Jan 28, 2024

Thank you very much for your feedback!

I've found the source of the bug, and it seems I can fix it. (The multiline questions were not tested well with Windows line endings [CR LF].) I can upload a new release tomorrow, but I'll write here too, when it'll be available to use.

Thank you again, and have a nice day/evening!

Krazal added a commit that referenced this issue Jan 30, 2024
• New feature added: instructions (OpenAI system messages)
• Fixed some bugs, e.g. wrong EOLs (Issue #19)
• Some code rearranging
• Up-to-date certificates (cacert.pem)
• README.md updates for the instructions
@Krazal
Copy link
Owner

Krazal commented Jan 30, 2024

Thank you for your patience!

The bug has been fixed in v0.3.0.0 release:
https://github.com/Krazal/nppopenai/releases/tag/v0.3.0.0

Additionally I finally released the system messages. (I call them „instructions”.) I think it may have a lot of possibility as I mentioned it in the N++ Community:
https://community.notepad-plus-plus.org/post/92156

I've sent a PR to nppPluginList repository, and hopefully the updates of the plugin will be available in N++ Plugins Admin soon.

I hope you find the updates useful!

@Krazal Krazal closed this as completed Jan 30, 2024
@BernoulliBox
Copy link
Author

Thank you for the quick and efficient resolution to the issue - the update works perfectly with Windows line ending characters (CR-LF) and the issue of double line spacing is completely resolved. I'm sure others who rely on Windows EOLs in their workflows will also benefit from this update!

The ability add a System message in a file is also super useful. As a future improvement idea, maybe we could have multiple System Message files available, and choose among them from the NppOpenAI plugin menu - that would be a cool way to keep a list of different 'personalities' ready to work!

I like the simplicity and elegance of working with OpenAI using this plugin. For coding, and other things too! Like recipes for baking bread, or planning a vacation, designing electronics, - the possibilities are endless!

@Krazal
Copy link
Owner

Krazal commented Feb 5, 2024

I'm glad to hear that the update works fine! ^^

It's a great idea about the System Messages! Last week a new project has been created, and now I've added an Improve System Message (instructions) task. It seems relatively easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants