Core: Fix regression in jQuery.text() on HTMLDocument objects

Fixes jquery#5264.
Krinkle · Jun 1, 2023 · 57065e2 · 57065e2
1 parent 992a665
commit 57065e2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/core.js b/src/core.js
@@ -289,8 +289,10 @@ jQuery.extend( {
 				// Do not traverse comment nodes
 				ret += jQuery.text( node );
 			}
-		} else if ( nodeType === 1 || nodeType === 9 || nodeType === 11 ) {
+		} else if ( nodeType === 1 || nodeType === 11 ) {
 			return elem.textContent;
+		} if ( nodeType === 9 ) {
+			return elem.documentElement.textContent;
 		} else if ( nodeType === 3 || nodeType === 4 ) {
 			return elem.nodeValue;
 		}

diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
@@ -30,9 +30,9 @@ function manipulationFunctionReturningObj( value ) {
 
 QUnit.test( "text()", function( assert ) {
 
-	assert.expect( 5 );
+	assert.expect( 6 );
 
-	var expected, frag, $newLineTest;
+	var expected, frag, $newLineTest, doc;
 
 	expected = "This link has class=\"blog\": Simon Willison's Weblog";
 	assert.equal( jQuery( "#sap" ).text(), expected, "Check for merged text of more then one element." );
@@ -52,6 +52,9 @@ QUnit.test( "text()", function( assert ) {
 	assert.equal( $newLineTest.text(), "test\ntesty", "text() does not remove new lines (trac-11153)" );
 
 	$newLineTest.remove();
+
+	doc = new DOMParser().parseFromString( "<span>example</span>", "text/html" );
+	assert.equal( jQuery( doc ).text(), "example", "text() on HTMLDocument (gh-5264)" );
 } );
 
 QUnit.test( "text(undefined)", function( assert ) {