Present modal with custom transition

[mluisbrown]

Changed to make view controller presentable as modal VC using custom transition.
Only made a custom transition for the presentation, not the dismissal, where it's not necessary (uses the existing animation).

[RuiAAPeres]

I was testing this on a real device, and there is a point when you dismiss the ImageViewer, and the entire UI stops receiving touches.With the Close Button action to dismiss, it works. When you flip to dismiss, the rest of the UI stops responding.

[RuiAAPeres]

Ok, so with the Close Button action to dismiss, it works. When you flip to dismiss, the rest of the UI stops responding.

[mluisbrown]

Ok sorry, forgot to adjust the swipe to dismiss code to handle VC being presented. Now fixed.

[RuiAAPeres]

It's working now. Do you think it would take a lot of work to use transitions for the dismiss? This way we would close the circle.

[RuiAAPeres]

@mluisbrown Btw, do you still need this code?

        guard let rootController = self.applicationWindow?.rootViewController else { return }

        self.view.frame = UIScreen.mainScreen().bounds
        self.applicationWindow!.addSubview(self.view)
        rootController.addChildViewController(self)
        self.didMoveToParentViewController(rootController)

[mluisbrown]

Shouldn't be too much work to use transitions for the dismiss too. Regarding that code block, it depends if you want to be maintain the ability to use show() instead of presentViewController. If not, then we can remove the show method altogether (and a few other ifs where we check if the VC was presented or not)

[RuiAAPeres]

I was thinking about adding an extension to a UIViewController:

extension UIViewController {

   func presentImageViewer(imageViewer: ImageViewer, completion: Void -> Void = {}) {
      self.presentModalViewController(imageViewer, completion: completion)
  }
}

The thing is, if you don't remove the show, then you can't remove this as well:

-                    self.view.removeFromSuperview()                         
-                    self.removeFromParentViewController()

By removing the show, it makes the inner logic simpler.

[RuiAAPeres]

@mluisbrown what's your feeling about the extension on an UIViewController?

[mluisbrown]

I think it's a great idea.

[RuiAAPeres]

you can remove internal, it is by default.

[RuiAAPeres]

A small bug with the status bar:

[mluisbrown]

Made changes as per your suggestions. Status bar jump is fixed, but in-call status bar behaviour remains awful. I couldn't find a solution. Using windowLevel doesn't work either and is actually worse (ImageView window shifts down with no visible status bar)