Fix shader compilation on certain devices #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarph
pushed a commit
to skarph/Kristal
that referenced
this pull request
Dec 30, 2023
…-fix Fix shader compilation on certain devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly changes ints that are supposed to be floats to actual floats. Seems like GLES ES compilers don't like it when you put ints in places when you should put floats, probably because the spec doesn't want you to do it; sometimes there are no function overloads that account for doing so, sometimes the compiler complains when you try to compare a int with a float. I have no clue, I'm not good at shader stuff.
TODO: