Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serfs should start delivering stone/timber to Builders as soon as they start the work on road/wine plans #9

Closed
TehPlayer14 opened this issue Mar 26, 2015 · 13 comments

Comments

@TehPlayer14
Copy link

TehPlayer14 commented Mar 26, 2015

Serfs should go for the stone/wood when Builders start digging (like in TPR)

@Kromster80 Kromster80 changed the title Missing ealier resource deliver to builders Serfs should start delivering stone/timber to Builders as soon as they start the work on road/wine plans Mar 26, 2015
@Kromster80
Copy link
Owner

Did this really work like so in TPR ? I had an impression that in TSK and TPR serfs acted the same, going to deliver the stone/wood only after the worker would started working on the plan and paused in need for the stone/wood.

All in all though, this would be a good improvement.

@TehPlayer14
Copy link
Author

Here you go its old video but still it explains it was there https://youtu.be/x2ayjxaioEE

The diffrence was in vid about ~2s

@Kromster80
Copy link
Owner

Thanks for the reference! :-)

@avdept
Copy link

avdept commented Mar 27, 2015

I always thought that mats were delivered only when worker stopped preparing for building. This makes sense if for ex. your worked died or was killed in action, and therefore serf wastes lots of time to return(if no killed)

@Kromster80
Copy link
Owner

99.9% of the time worker would not die, so we can slice off these 5-8 seconds of each road, that can add to a very significant number indeed :-)

@avdept
Copy link

avdept commented Mar 27, 2015

It's your decision, but imagine real life. Are bricks being delivered when workers building safe wall?


Sent from Mailbox

On Fri, Mar 27, 2015 at 6:48 PM, Kromster80 notifications@github.com
wrote:

99.9% of the time worker would not die, so we can slice off these 5-8 seconds of each road, that can add to a very significant number indeed :-)

Reply to this email directly or view it on GitHub:
#9 (comment)

@Kromster80
Copy link
Owner

What do you mean?

On 27.03.2015 19:52, Alex Sinelnikov wrote:

It's your decision, but imagine real life. Are bricks being delivered
when workers building safe wall?


Sent from Mailbox

On Fri, Mar 27, 2015 at 6:48 PM, Kromster80 notifications@github.com
wrote:

99.9% of the time worker would not die, so we can slice off these
5-8 seconds of each road, that can add to a very significant number

indeed :-)

Reply to this email directly or view it on GitHub:
#9 (comment)


Reply to this email directly or view it on GitHub
#9 (comment).

@Kromster80 Kromster80 added this to the Future version milestone Mar 28, 2015
@Kromster80 Kromster80 self-assigned this Mar 28, 2015
@Kromster80
Copy link
Owner

Implemented. Will be in next release.

@TehPlayer14
Copy link
Author

Whoa Nice Thanks Krom

@TehPlayer14
Copy link
Author

Will be there soon a new version including it ? because it can change gameplay quite a lot

It will speed up building in general.

@Tassl3hoff
Copy link

This won't nerf the computer AI will it.

@Kromster80
Copy link
Owner

@michal1324: Maybe next year.
@Tassl3hoff: I can not understand what you mean by that.

@LauraRozier
Copy link
Contributor

@Kromster80 , about what @Tassl3hoff wrote, I think what the worries are that it might give the enemy AI a disadvantage over the players, by building the roads slower.
Yet, due to the huge amount of reading the code I did for the fix of the ArmorSmithy, I read through the full serf action handling and by accident also that of the worker, I am sure it will not.
The AI uses the same classes for serfs and workers, for as far as I know.
It should be the same even with the enhancement. :)
You build roads a bit faster but the AI will too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants