Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to remove ugly horizontal line above module attributes #798

Closed
mkaput opened this issue Aug 18, 2017 · 3 comments · Fixed by #1788
Closed

Add possibility to remove ugly horizontal line above module attributes #798

mkaput opened this issue Aug 18, 2017 · 3 comments · Fixed by #1788

Comments

@mkaput
Copy link

mkaput commented Aug 18, 2017

Is there an option to remove/hide this line above @doc? I cannot find anything related nor even I don't know how it's called.

zrzut ekranu z 2017-08-18 10-39-31

@KronicDeth
Copy link
Owner

The line is not above all module attributes: it is above the group of @doc, @spec, and call definition clauses that are associated.

You can turn them off in Preferences > Editor > General > Appearance.

screen shot 2017-08-18 at 12 07 28 pm

They're called Method Separators.

If you're wondering why they're called "method" and not "definition" separators, it's because it's a cross-language settings, so the name is the one IntelliJ uses for Java. I don't control that part of the menu structure.

@mkaput
Copy link
Author

mkaput commented Aug 21, 2017

Sorry for late response, but I don't have Elixir set up on my personal machine and had to try it at work.

I already have this option turned off (and I think it's off by default):
obraz

@seanwash
Copy link
Contributor

seanwash commented Jul 3, 2019

Sort of the opposite, but I really like the method separators. Is there any way to configure things so that they appear above the describe and test macros as well? I'd be happy to provide a PR if I could get some guidance.

-- Update

I also tested turning that setting off (making sure to click apply and ok) and it appears that the method separators are still active.

KronicDeth added a commit that referenced this issue Jun 5, 2020
Fixes #798

Previously, unchecking Show Method Separator would still show the method separator if it was the module attributes (such as `@doc` and `@spec`) associated with the call definition (`def`, `defp`, `defmacro`, or `defmacrop`) existed and only disabled the ones directly above the call definiton.  This is fixed by checking if method separators are enabled in `getLineMarkerInfo(PsiElement)` instead of the specialized `getLineMarkerInfo(Call)`, so that the check happens for both module attributes and call definitions.
@KronicDeth KronicDeth added this to the v11.8.0 milestone Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants