Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end is not an allowed keyword key #821

Closed
IcyEagle opened this issue Sep 4, 2017 · 1 comment
Closed

end is not an allowed keyword key #821

IcyEagle opened this issue Sep 4, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@IcyEagle
Copy link

IcyEagle commented Sep 4, 2017

Hi.

This code works good, but there is a problem with highlighting.
Is it possible to fix it?

4d7ee25922

Thanks!

@KronicDeth
Copy link
Owner

Yeah, I noticed that end had to be protected as "end": when helping @StabbyMcDuck with her talk for ElixirConf. Definitely a bug. END is not a listed token in keywordKey grammar rule

keywordKey ::= AFTER |
ALIAS_TOKEN |
AND_SYMBOL_OPERATOR |
AND_WORD_OPERATOR |
ARROW_OPERATOR |
ASSOCIATION_OPERATOR |
AT_OPERATOR |
BIT_STRING_OPERATOR |
CAPTURE_OPERATOR |
CATCH |
COMPARISON_OPERATOR |
DO |
DIVISION_OPERATOR |
DUAL_OPERATOR |
ELSE |
IDENTIFIER_TOKEN |
IN_MATCH_OPERATOR |
IN_OPERATOR |
MAP_OPERATOR |
MATCH_OPERATOR |
MULTIPLICATION_OPERATOR |
NIL |
NOT_OPERATOR |
OR_SYMBOL_OPERATOR |
OR_WORD_OPERATOR |
PIPE_OPERATOR |
RANGE_OPERATOR |
RESCUE |
RELATIONAL_OPERATOR |
STAB_OPERATOR |
STRUCT_OPERATOR |
THREE_OPERATOR |
TUPLE_OPERATOR |
TWO_OPERATOR |
UNARY_OPERATOR |
WHEN_OPERATOR |
quote
{
implements = [
"org.elixir_lang.psi.NamedElement"
"org.elixir_lang.psi.Quotable"
]
methods = [
getName
getNameIdentifier
quote
setName
]
}

It may also need to have proper lexer changes to check for : after it like do has.

@KronicDeth KronicDeth added this to the v6.2.0 milestone Sep 5, 2017
@KronicDeth KronicDeth changed the title Wrong highlighting when a keyword used as a "key" in a Map end is not an allowed keyword key Sep 5, 2017
@KronicDeth KronicDeth self-assigned this Sep 30, 2017
KronicDeth added a commit that referenced this issue Oct 1, 2017
KronicDeth added a commit that referenced this issue Oct 1, 2017
KronicDeth added a commit that referenced this issue Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants