Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved kiex home path validation and adjustment. #1445

Merged
merged 6 commits into from Apr 13, 2019
Merged

Improved kiex home path validation and adjustment. #1445

merged 6 commits into from Apr 13, 2019

Conversation

KronicDeth
Copy link
Owner

Fixes #1441

Changelog

Enhancements

  • Replace comparator with Comparator.reverseOrder()
  • The correct home path for kiex is ~/.kiex/elixirs/elixir-VERSION/lib/elixir as that contains the true lib and bin directory, but users may select other directories by mistake, so doing the following adjustments:
    • Adjust bin home path to lib/elixir.
    • Adjust elixirs/elixir-VERSION home path to elixirs/elixir-VERSION/lib/elixir.

Bug Fixes

  • Remove obsolete SdkType. I keep confusing it with its replacement org.elixir_lang.sdk.elixir.Type!
  • Check that HomePath has ebin paths when validation. Prevents selecting false HomePaths for kiex.

I keep confusing it with its replacement
`org.elixir_lang.sdk.elixir.Type`!
Prevents selecting false home paths in kiex
Adjusted to elixirs/elixir-VERSION/lib/elixir.
@KronicDeth KronicDeth merged commit e90c969 into master Apr 13, 2019
@KronicDeth KronicDeth deleted the 1441 branch April 13, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select SDK step doesn't detect Elixir binaries for kiex + homebrew Erlang
1 participant