Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.8 debugger #1491

Merged
merged 3 commits into from May 26, 2019
Merged

1.8 debugger #1491

merged 3 commits into from May 26, 2019

Conversation

KronicDeth
Copy link
Owner

@KronicDeth KronicDeth commented May 26, 2019 •
edited

Test Report

Tested using eex_test_umbrella and evaluating parameters using Elixir 1.7.4 and 1.8.1.

Changelog

Bug Fixes

  • Elixir 1.8 made :elixir.quoted_to_erl/3 private, so in Elixir 1.8+, the debugger needs to inline the private version to maintain < 1.8 and >= 1.8 compatibility.
  • Reformat debugger for Elixir 1.8

@KronicDeth
Inline :elixir.quoted_to_erl/3 in 1.8+
1bd56d3 
Fixes #1421
Fixes #1466
Fixes #1474

Elixir 1.8 made `:elixir.quoted_to_erl/3` private, so in Elixir 1.8+,
the debugger needs to inline the private version to maintain < 1.8 and
>= 1.8 compatibility.
@KronicDeth
Elixir 1.8 mix format
afe38d5
@KronicDeth KronicDeth added this to the 10.5.2 milestone May 26, 2019
@KronicDeth KronicDeth self-assigned this May 26, 2019
@KronicDeth KronicDeth merged commit e26cd9c into master May 26, 2019
@KronicDeth KronicDeth deleted the 1.8-debugger branch May 26, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KronicDeth KronicDeth

Labels
Feature:Debugger Kind:Bug
Projects
None yet
Milestone
10.6.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@KronicDeth