Fix ConcurrentModificationException in Structure View #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1488 Java 9 fixed a bug (https://bugs.openjdk.java.net/browse/JDK-8071667) in `HashMap` where `computeIfAbsent` did not check for concurrent modifications, and it turns out that `TreeElementList` was using concurrent modifications, so it was now broke. Fixed by use `get` or `put` if it is absent, so that `putNew` can ensure that the `CallDefinition` is in the `TreeElementList` before it is added to the `MutableList<TreeElement>`, which was the original reason why there was a `put` inside of `computeIfAbsent`, which would have `put` when the function returned anyway.
KronicDeth
force-pushed
the
concurrent-modification-exception
branch
from
a9612d9
to
2283e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1488
Changelog
Bug Fixes
Fix
ConcurrentModificationExceptionin Structure ViewJava 9 fixed a bug (https://bugs.openjdk.java.net/browse/JDK-8071667) in
HashMapwherecomputeIfAbsentdid not check for concurrent modifications, and it turns out thatTreeElementListwas using concurrent modifications, so it was now broke.Fixed by use
getorputif it is absent, so thatputNewcan ensure that theCallDefinitionis in theTreeElementListbefore it is added to theMutableList<TreeElement>, which was the original reason why there was aputinside ofcomputeIfAbsent, which would haveputwhen the function returned anyway.