Fix underscore in numbers causing a syntax error #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 23, 2019 14:35
* Fix DecimalIntegerTest
IIRC that is just the newer version of GrammarKit adding them. |
|
Confirmed #1478 test cases worked manually. Fixing test failures now. |
|
Thank you very much for fixing the tests and merging the fix. Will check tomorrow whether the tests still don't work locally, just in case I get to do any other merges (don't want to always let you do the dirty work 😅 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1478 . I wrote the fix last year in May, but had a ton of tests failing. Yesterday I merged your current master branch and with
runIdethe bug was still fixed. Unfortunately when running thetesttask it gets stuck indefinitely in therunQuotertask. A colleague has the same problem and left it running for 4 hours.I'm also not sure why there are so many
@Overridein the diff. I unmarked thegenfolder as generated source (as far as I can recall). If it's a problem I can go through the changes and remove them.Changelog
Bug Fixes
0b), octal (0o) , and hexadecimal (0x) numbers.