Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Icon issue for IntelliJ 2020.1 #1738

Merged
merged 7 commits into from Apr 10, 2020
Merged

Conversation

Koziolek
Copy link
Contributor

@Koziolek Koziolek commented Apr 10, 2020

Change old references to new that are recommended by documentation.

Happy Easter Eggs

Changelog

Enhancements

  • Update build to IntelliJ IDEA 2020.1

Bug Fixes

  • JetBrains IDEs 2020.1 compatibility
    • Change obsolete references to AllocIcons in Icons to new ones in AlllIcons that are recommended in documentation.
    • Update to @NotNull annotation on PsiElementVisitor
      • DepGatherer
      • QuotableImpl.quote

@emhagman
Copy link

Fixes #1654

@Koziolek
Copy link
Contributor Author

@emhagman – I have some strange during build. Based on https://github.com/KronicDeth/intellij-elixir/blob/master/RELEASING.md but it is not working as expected.

@KronicDeth KronicDeth self-assigned this Apr 10, 2020
@Koziolek
Copy link
Contributor Author

@KronicDeth I made some extra changes to compile this stuff.

@Koziolek
Copy link
Contributor Author

Koziolek commented Apr 10, 2020

@emhagman my local build is here → http://koziolekweb.pl/Elixir-11.6.1-pre+20200410195935.zip
No guarantee that works fine and don't burn your machine.

@KronicDeth KronicDeth merged commit 9ff436d into KronicDeth:master Apr 10, 2020
@KronicDeth
Copy link
Owner

Official build is happening here

@KronicDeth
Copy link
Owner

Thanks for all your help @Koziolek ❤️

@nitingupta910
Copy link

Official build is happening here

It didn't go through, it seems.

@KronicDeth
Copy link
Owner

Huh, well that is interesting that it was build compilable, but not test compilable. That's why we have tests I guess. Investigating @nitingupta910

@Koziolek
Copy link
Contributor Author

Fixed in #1744 but I'm not happy of that.

@nitingupta910
Copy link

Fixed in #1744 but I'm not happy of that.

IDE still doesn't see any plugin updates. No hurry but just want to let you know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants