Fix test compilation for 2020.1 #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KronicDeth
force-pushed
the
2020.1-test-compatibility
branch
from
adddd5e
to
82b2be1
Compare
0.48 is incompatible with 2020.1 testing by causing ``` java.lang.IllegalStateException: @NotNull method com/maddyhome/idea/vim/VimPlugin.getInstance must not return null ```
KronicDeth
force-pushed
the
2020.1-test-compatibility
branch
from
5048a56
to
0e8eebc
Compare
It causes an UnsupportedOperationException in 2020.1 ``` ava.lang.UnsupportedOperationException at com.intellij.openapi.components.ComponentManager.getComponentInstancesOfType(ComponentManager.java:204) at com.intellij.openapi.components.ComponentManager.getComponents(ComponentManager.java:73) at com.intellij.openapi.projectRoots.SdkType.getAllTypes(SdkType.java:222) at com.intellij.openapi.projectRoots.impl.ProjectJdkTableImpl.findSdkTypeByName(ProjectJdkTableImpl.java:295) at com.intellij.openapi.projectRoots.impl.ProjectJdkTableImpl.getSdkTypeByName(ProjectJdkTableImpl.java:290) at org.elixir_lang.sdk.elixir.Type.erlangSdkType(Type.java:339) ```
Some components became services and the order of startup changed.
KronicDeth
force-pushed
the
2020.1-test-compatibility
branch
from
0e8eebc
to
4d96490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Bug Fixes