Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Run icon in gutter next to ExUnit tests #1807

Merged
merged 2 commits into from Aug 4, 2020

Conversation

niknetniko
Copy link
Contributor

  • This PR adds the "run" icons in the gutter for tests:
    image

  • There are also some small clean-ups in related code.

For the run icons:

  • They use the existing run actions, same as when you right-click.
  • They only appear of the file is a test file (suffix _test.exs and in a map marked as tests in the project structure)
  • I have no idea how one should write a test for this stuff, so I didn't (I'm fairly new to Intellij SDK stuff)
  • I hardcoded "test", "describe", "doctest" and "defmodule". I don't know if it would be better to dynamically determine these, but that would be fairly hard I think.

I have been using this some time in a personal fork and it seems to work pretty well.

Fixes #688.

@KronicDeth
Copy link
Owner

I have no idea how one should write a test for this stuff, so I didn't (I'm fairly new to Intellij SDK stuff)

Yeah, I usually don't know how to test most of the stuff in the UI. JetBrains has told me before that they don't really write UI tests, so I'm not sure how to test this. Some of the UI stuff ends up being is a line marker attached to the correct line.

@KronicDeth KronicDeth merged commit 32c3776 into KronicDeth:master Aug 4, 2020
@KronicDeth KronicDeth added this to the v11.8.0 milestone Aug 4, 2020
@niknetniko niknetniko deleted the feature/test-markers2 branch August 4, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Run icon in gutter next to ExUnit tests
2 participants