Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render OtpErlangExternalFun correctly as remote captures (&Mod.fun/arity) #2441

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

KronicDeth
Copy link
Owner

@KronicDeth KronicDeth commented Jan 3, 2022

Changelog

Bug Fixes

  • Render OtpErlangExternalFun correctly as remote captures (&Mod.fun/arity).
    Fixes decompiling Ecto.Changeset.validate_number.

@KronicDeth KronicDeth added this to the 12.1.0 milestone Jan 3, 2022
@KronicDeth KronicDeth merged commit 666df48 into main Jan 4, 2022
KronicDeth added a commit that referenced this pull request Jan 5, 2022
Resolves #2386

Issue #2386 had the same root cause (OtpExternalFun not being decompiled correctly) as #2410, so #2386 was fixed by #2441, but since @alexxero was nice enough to upload the `.beam` file for #2386, I might as well add it as a regression test too.
KronicDeth added a commit that referenced this pull request Jan 5, 2022
Resolves #2386

Issue #2386 had the same root cause (OtpExternalFun not being decompiled correctly) as #2410, so #2386 was fixed by #2441, but since @alexxero was nice enough to upload the `.beam` file for #2386, I might as well add it as a regression test too.
KronicDeth added a commit that referenced this pull request Jan 5, 2022
Resolves #2386

Issue #2386 had the same root cause (OtpExternalFun not being decompiled correctly) as #2410, so #2386 was fixed by #2441, but since @alexxero was nice enough to upload the `.beam` file for #2386, I might as well add it as a regression test too.
@KronicDeth KronicDeth deleted the 2410 branch January 9, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant