Multiple Aliases parsing and Go To Declarations #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the ability to quote multiple aliases, but no references yet. Ports elixir-lang/elixir#3666.
canonicalName borrows from the idea of PsiReference#canonicalText: an element can have both a Name (from getName), which is the literal name in the code, which can be renamed, and a Canonical Name, which is the name to refer to the element without need for imports or aliases. For this change, defimpl, defmodule, and defprotocol will show their full module Alias for their Canonical name. This change addresses the use case of Go To Declaration that should resolved to a nested defmodule.
fullyQualifiedName is needed so that qualified aliases inside of the { }
of a multiple alias will have a name as getName is null for those
qualified aliases because the name from getName has to be a literal name
that can be renamed and qualified names can't be renamed.
KronicDeth
added a commit
that referenced
this pull request
Aug 5, 2016
KronicDeth
referenced
this pull request
in elixir-lang/elixir
Aug 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217
Changelog
Enhancements
Regenerate parser with GrammarKit 1.4.2
ElixirSdkReleaseis nowComparable, so version checks can be done for tests to restrict them to Elixir 1.2+ for multiple alias support.Resolve Multiple Aliases with unqualified Alias in tuples.
canonicalNameborrows from the idea ofPsiReference#canonicalText: an element can have both a Name (fromgetName), which is the literal name in the code, which can be renamed, and a Canonical Name, which is the name to refer to the element without need for imports or aliases. For this change,defimpl,defmodule, anddefprotocolwill show their full module Alias for their Canonical Name.This change addresses the use case of Go To Declaration that should
resolved to a nested
defmodule.Bug Fixes
A.{B, C}to grammar with quoting to check consistence with Elixir 1.2. Ports elixir-lang/elixir#3666.fullyQualifiedNameinstead ofgetNameforresolvableNamebecausefullyQualifiedNameis needed so that qualified aliases inside of the{ }of a multiple alias will not have a name asgetNameisnullfor those qualified aliases because the name fromgetNamehas to be a literal name that can be renamed and qualified names can't be renamed.