Ship copy of GeneratedParserUtilBase #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated ElixirParser uses the GeneratedParserUtilBase from com.intellij.lang.parser, but since that version is a synced copy, it is a snapshot of GeneratedParserUtilBase from the version of GrammarKit that was current when the IDE was released. To ensure the generated parser works on all the IDEs, copy GeneratedParserUtilBase from org.intellij.grammar.parser into org.elixir_lang.grammar.parser and then use that version in ElixirParser. This ensures neither the IDE's version nor the version in any installed GrammarKit plugin is used. NOTE: This copy needs to be updated if the build machine updates its GrammarKit plugin. So, I'm fixing errors from intellij-community having a sync-ed copy of GeneratedParserUtilBase, by making my own synced copy...
KronicDeth
added a commit
that referenced
this pull request
Sep 2, 2016
This was referenced Sep 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293
Fixes #302
Fixes #328
Fixes #385
Fixes #386
Fixes #391
Fixes #402
Changelog
Bug Fix
The generated
ElixirParseruses theGeneratedParserUtilBasefromcom.intellij.lang.parser, but since that version is a synced copy, it is a snapshot ofGeneratedParserUtilBasefrom the version of GrammarKit that was current when the IDE was released. To ensure the generated parser works on all the IDEs, copyGeneratedParserUtilBasefromorg.intellij.grammar.parserintoorg.elixir_lang.grammar.parserand then use that version inElixirParser. This ensures neither the IDE's version nor the version in any installed GrammarKit plugin is used.NOTE: This copy needs to be updated if the build machine updates its
GrammarKit plugin.
So, I'm fixing errors from intellij-community having a sync-ed copy of
GeneratedParserUtilBase, by making my own synced copy...