Look through NoParenthesesStrict for parameters #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, the excerpt doesn't have enough context, and it's not safe to search for more context (as those PSI walking methods have also had errors before), so include the element class in the message, which has the benefit that most times the bugs are fixed by adding that class or an interface of that class to one of the methods AND it will make the error message different, so that users don't think other users have the same error and jump on the issue instead of opening a new one.
`ElixirNoParenthesesStrict` can occur in `def (conn, %{}) do\nend` when a
template is used, so there is no name for `def`. Since the intent is
known, mark `conn` as a parameter by checking the parent of the
`ElixirNoParenthesesStrict`, which eventually gets to the `def`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
Changelog
Enhancements
Bug Fixes
ElixirNoParenthesesStrictcan occur indef (conn, %{}) do\nendwhen a template is used, so there is no name fordef. Since the intent is known, markconnas a parameter by checking the parent of theElixirNoParenthesesStrict, which eventually gets to thedef.