Improve logging for CallDefinitionClause.renderElement #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiResolve causes a StackOverflow for org.elixir_lang.annotator.Callable.visitCall, when catch it and use errorreport logger to log the element.
Prevents stack overflow due to recursive import.
Fixes #606 Use advice from IndexNotReadyException documentation and check DumbService.isDumb(Project) before calling StubIndex.getElements.
…eption Fixes #606 Use advice from IndexNotReadyException documentation and check DumbService.isDumb(Project) before calling StubIndex.getElements.
Fixes #563 Log what is Object when there is no PsiElement in LookupElement.
KronicDeth
added a commit
that referenced
this pull request
Feb 10, 2017
This was referenced Feb 10, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #563
Changelog
Enhancements
multiResolvecauses aStackOverflowfororg.elixir_lang.annotator.Callable.visitCall, thencatchit and useerrorreportlogger to log the element.errorreportexcerptStackOverflowrelated toimportsLookupElement#getObjectwhenLookupElement#getPsiElementisnullto track down how it wasnullin [auto-generated] java.lang.AssertionError at org.elixir_lang.code_insight.lookup.element_renderer.CallDefinitionClause.renderElement #563.Bug Fixes
import Kernelinkernel.exto prevent stack overflow due to recursiveimport(+value)can be see as+operator type spec.IndexNotReadyExceptiondocumentation and checkDumbService.isDumb(Project)before callingStubIndex.getElementsinModuleandmodule.MultiResolve.indexNameElements.assertthatLookupElement#getPsiElementis notnullinCallDefinitionCluase.renderElementant1.10.1because1.10.0is no longer hosted.