Don't highlight resolved callable if in a different file #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #626 Annotations can only be applied to the single, active file, which belogns to the referrer. The resolved may be outside the file if it is a cross-file function or macro usage.
This was referenced Feb 24, 2017
KronicDeth
added a commit
that referenced
this pull request
Feb 24, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #619
Fixes #625
Fixes #626
Changelog
Bug Fixes
referrerCallable. Theresolvedmay be outside the file if it is a cross-file function or macro usage, in which case it'sTextRangeshould not be highlighted because it is referring to offsets in a different file.