Fix highlighting of function definitions with guard clauses #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The run configurations I put together in #504 didn't allow for the debugger to work properly: neither pause nor breakpoints had any effect.
The callable annotator is meant for variables, parameters, and macro and function calls and declarations. The ModuleAttribute annotator handles ModuleAttribute declaration and usage, so we can save reference resolution time by skipping module attributes in Callable.
Instead of highlighting call definition clauses when they are referred to, which only works if it is in the same file, highlight all function and macro declarations when the def* call is encountered.
KronicDeth
changed the title
KronicDeth
added a commit
that referenced
this pull request
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #571
Changelog
Enhancements
Callableannotator is meant for variables, parameters, and macro and function calls and declarations. The ModuleAttribute annotator handles ModuleAttribute declaration and usage, so we can save reference resolution time by skipping module attributes in Callable.Bug Fixes
whenoperation in case it's a guarded function head inorg.elixir_lang.annonator.Parameter.putParameterized(Parameter, PsiElement)def*call is encountered.