Bug Fixes #662
Merged
Bug Fixes #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without overrideing #getProject, IdentifierHighlighterPass gets stuck in a loop between getManager and getProject on the target (the ModuleImpl) when clicking on the space between defs or defmacros in the decompiled .beam files.
This gives consistency with Aliases for defmodule.
In addition to the current CallDefinitionClause, make it work for Implementation, Module, and Protocol.
Anything with a do keyword or a do block will be treated like a macro call even if it can't be resolved.
In addition to top of Module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various bugs found and fixed while trying to fix #578, which didn't work out due to problems with too many references.
Changelog
Enhancements
defmodule.Callable.callDefinitionClauseDefiner(Call): in addition to the currentCallDefinitionClause, make it work forImplementation,Module, andProtocol.Bug Fixes
ModuleImpl#getProject()to preventStackOverflowError. Without overriding#getProject(),IdentifierHighlighterPassgets stuck in a loop betweengetManagerandgetProjecton the target (theModuleImpl) when clicking on the space betweendefs ordefmacros in the decompiled.beamfiles.