Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing breaks to case statement in processDeclarations(Match, ...) #755

Merged
merged 2 commits into from Jul 30, 2017

Conversation

KronicDeth
Copy link
Owner

Fixes #687

Changelog

Enhancements

Bug Fixes

  • Add missing breaks to case statement in processDeclarations(Match, ...) that caused the logic of whether to check left, right, or both operand based on the whether the treeWalkUp came from always fell through to the RIGHT case, so it was only, always checking the right operand of the match and never the left operand.

Fixes #687

A bit too much Ruby and Elixir and I forgot breaks in my case
statements in Java.
@KronicDeth KronicDeth added this to the v6.0.0 milestone Jul 30, 2017
@KronicDeth KronicDeth self-assigned this Jul 30, 2017
@KronicDeth KronicDeth merged commit 22f507b into master Jul 30, 2017
@KronicDeth KronicDeth deleted the 687 branch July 30, 2017 12:36
KronicDeth added a commit that referenced this pull request Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant