Delegate ChildAttributes to previous child when available
#782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's annoying to have to install whenever the sandbox resets.
Fixes #770 Block.getChildAttributes is used when Enter is pressed to determine the indentation and alignment. Using the default implementation, newlines in stabs look overly indented, but there is a constant, `DELEGATE_TO_PREV_CHILD` that can be used to just use the last child's indent as long as there is one, which appears to work well for stabs (do block bodies, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779
Changelog
Enhancements
IdeaVIMin the gradle sandbox because it got annoying having to reinstall it when the sandbox reset.Bug Fixes
ChildAttributesto previous child when available:Block.getChildAttributesis used when Enter is pressed to determine the indentation and alignment. Using the default implementation, newlines in stabs look overly indented, but there is a constant,DELEGATE_TO_PREV_CHILDthat can be used to just use the last child's indent as long as there is one, which appears to work well for stabs (do block bodies, etc).