This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Deleted translation MsAccess to SqlServer syntax. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satano
suggested changes
May 7, 2018
| @@ -31,312 +27,7 @@ public SqlServerQuerySqlGenerator(IDatabaseMapper databaseMapper) | |||
| /// </returns> | |||
| public override string GenerateSql(Expression expression) | |||
There was a problem hiding this comment.
This method can be deleted. But as I see, whole class can be removed - it does not do anything now.
There was a problem hiding this comment.
Yes, but then I would have to use DefaultQuerySqlGenerator which is Abstract. Should I change it?
There was a problem hiding this comment.
Yes, why not. There is no abstract method in DefaultQuerySqlGenerator anyway.
satano
approved these changes
May 7, 2018
|
@LukasSefcik , can you write info about this breaking change to Kros.KORM v3.7.0 Milestone? Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11