Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Powered by Krypton Toolkit button #1009

Open
giduac opened this issue Apr 22, 2023 · 51 comments
Open

[Feature Request]: Powered by Krypton Toolkit button #1009

giduac opened this issue Apr 22, 2023 · 51 comments
Labels
enhancement New feature or request in progress A fix for this issue is in the works. new feature A new feature has been requested. suggestion A suggestion has been requested. version:100 All things to do with V100.
Milestone

Comments

@giduac
Copy link

giduac commented Apr 22, 2023

Describe the solution you'd like
Would it be an idea to add a Button or other type of control to emphasize the use of KToolkit and link to it and that developers can incorporate into their programs...

These options are disabled for now (06-20-2024) and will be not in V90. until there's more time.
All components will be hidden from the toolbox for now.

@giduac giduac added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. labels Apr 22, 2023
@Smurf-IV
Copy link
Member

That would be nice of developers to do that, but those sort of things go into about box's and / or license text that should be shipped with apps.
Not sure what "we" as "KToolkit maintainers" would need to do ?

@giduac
Copy link
Author

giduac commented Apr 23, 2023

@Smurf-IV @Wagnerp,

A possibility would be a preconfigured group box containing some info about KT. A link to the site/GitHub. The logo.
It's a possibility to shape this info and attract other developers, also a chance to create more exposure for the toolkit.

......

@Smurf-IV
Copy link
Member

Smurf-IV commented Apr 23, 2023

And as most apps have a theme changing component, then it could include that combo as well..

@Wagnerp
Copy link
Contributor

Wagnerp commented Apr 23, 2023

How about a preconfigured about box?

@Smurf-IV
Copy link
Member

Smurf-IV commented Apr 23, 2023

How about a preconfigured about box?

too restrictive, AS most about boxes need to have additional info about the actual app, with areas for licensed components, and actual licensed status etc.
So having a preconfigured "GroupBox" in the designer would mean the greatest flexibility

@giduac
Copy link
Author

giduac commented Apr 23, 2023

  1. Yeah, Hookup the KThemeCombo in there
  • although if a project has a fixed theme or uses only a couple of themes it would be needed to hide the Combo
  • Maybe leave that theme selection implementation to the dev...??
  1. Preconfigured Aboutbox is an option but adding an about-form to a project is no big deal. And as Surf says most projects summarize this kind of info on their own about box. (Yes and No). Rather a groupbox and a KAboutBox that uses the KAboutGroupBox..
  2. GroupBox could contain KT Version info of the Klibs loaded (if that makes sense)

Example where a preconfig wouldn't work that great:
image

I think

  • the GroupBox would be a good start and keep it manageable...
  • Incorporating the Theme Combo is not always desirable...

@giduac
Copy link
Author

giduac commented Apr 23, 2023

Another option/addition would be a KAboutButton with the Logo and a text like "About KT" / "Powered by KT", which displays a KAboutForm

@Wagnerp
Copy link
Contributor

Wagnerp commented Apr 23, 2023

@Smurf-IV Might be a good idea to use the KryptonLinkLabel for this, as you can specify a link area for the hyperlink

@giduac
Copy link
Author

giduac commented Apr 24, 2023

@Wagnerp @Smurf-IV, some more info that's needed I can think of,

  • The text for the KAboutGroupBox
  • Image(s) that possibly can be used
  • Link to the home page and/or Github & Nuget landing page (maybe more than one link)
  • Clearly state the intention of the link(s).
  1. That could go as far as a link tot the Github site for support.
  2. Invitation link for the Discord server
  3. Documentation homepage
  4. etc.
  • The components should be part of the Krypton Toolkit so they will always be available regardless which package the dev will use.
  • A KAboutButton that can be used to launch a KAboutform

I think displaying any system info would be redundant / Windows version / KLibs (since dev can see that in VStudio)..

Your input please....

@Wagnerp
Copy link
Contributor

Wagnerp commented Apr 24, 2023

It needs to be a drop-in component, restricting the editing of text should be easy, translations (if required) can be done via the new KryptonLanguageManager.

@Wagnerp
Copy link
Contributor

Wagnerp commented Apr 24, 2023

I don't know if we've done a KAboutForm yet... I guess we could take the default one from VB, CSharpify it, and modernise the layout? @Smurf-IV Thoughts?

Edit:

This looks good https://www.codeproject.com/Articles/7390/About-The-About-Box

image

@Wagnerp
Copy link
Contributor

Wagnerp commented Apr 24, 2023

The link I posted would kill two birds with one stone, look at the GIF in the article...

@giduac
Copy link
Author

giduac commented Apr 25, 2023

@Wagnerp @Smurf-IV
The (my)idea is to use a GroupBox as the (main) component that will contain all the information.
That Box will be available to devs so they can add it to their own about box.

Our AboutBox will contain that GroupBox as well.
Devs can launch that box by themselves. Or devs can use the KAboutButton that launches the KAboutBox

If info changes / needs updating than only the GroupBox component needs to be fixed.

I thought that might be the most simple way to do it and please all of them in one go ;)

@Wagnerp Wagnerp self-assigned this Oct 11, 2023
@Wagnerp Wagnerp added the in progress A fix for this issue is in the works. label Oct 11, 2023
@Wagnerp Wagnerp added this to the Version 8 milestone Oct 11, 2023
@Wagnerp
Copy link
Contributor

Wagnerp commented Oct 11, 2023

Going to try and implement this tomorrow

@Wagnerp
Copy link
Contributor

Wagnerp commented Oct 13, 2023

@giduac & @Smurf-IV

First itteration

image

Thoughts?

@Smurf-IV
Copy link
Member

I think it should also state the License type before the "Click here" link.
The Icon needs to move down so that it appear in line with the top of the text (Or move the text up !)
Documentation link is not necessary, as this is going into a published app. The Docs are for the developers, as is the discord link.
Need to have a title above the Theme combo, so that the "User" of the app knows what it is.

@Wagnerp
Copy link
Contributor

Wagnerp commented Oct 14, 2023

Hi @Smurf-IV

The Icon needs to move down so that it appear in line with the top of the text (Or move the text up !)

Trying to use a TableLayoutPanel isn't there some code in the KMbox which deals with something similar which could be reused?

@Smurf-IV
Copy link
Member

Try using the padding option 0, 10, 0, 0

@giduac
Copy link
Author

giduac commented Oct 14, 2023

@Wagnerp @Smurf-IV
My 2 cents

  • How about adding some context (how cool KT is) about what KT is all about...
  • Maybe an extra image which could be a sort of composite image of the controls available in KT. The current icon could be part of that.
  • Maybe there's somebody on the Discord channel who's handy with graphics and would like to whip-up one...
  • That image could also hold the header "Powered by KT", and give it some more punch
  • The theme-chooser could be a problem for devs that only use a couple of themes. In that case you don't want the user to go beyond that scope. Might also interfere with the theme chooser the dev is using already.
  • TableLayout in a groupbox should work just fine. Gives good control on positioning.

@Wagnerp
Copy link
Contributor

Wagnerp commented Oct 14, 2023

I'm thinking to also have the option to display the version of the toolkit DLLs being used?

@Wagnerp
Copy link
Contributor

Wagnerp commented Oct 14, 2023

@Smurf-IV

Try using the padding option 0, 10, 0, 0

Is that on the picturebox itself?

@Wagnerp
Copy link
Contributor

Wagnerp commented Oct 14, 2023

@giduac

The theme-chooser could be a problem for devs that only use a couple of themes. In that case you don't want the user to go beyond that scope. Might also interfere with the theme chooser the dev is using already.

That can be a option the dev can turn on/off, I think you can apply a filter to it also

@giduac
Copy link
Author

giduac commented Oct 14, 2023

@giduac

The theme-chooser could be a problem for devs that only use a couple of themes. In that case you don't want the user to go beyond that scope. Might also interfere with the theme chooser the dev is using already.
That can be a option the dev can turn on/off, I think you can apply a filter to it also

It also needs to be accessible to the dev if the theme selection is stored / restored on program shutdown and startup.
Yeah, an option to turn it off would be ok.
Anyways it should not interfere with a KManager & chooser that the dev is using already. So they can add the AboutBox to a project without a hassle.

Wagnerp added a commit that referenced this issue Oct 23, 2023
@Wagnerp
Copy link
Contributor

Wagnerp commented Oct 24, 2023

Which resources..... ?

Think the toolstrip default 'embedded' resources was the cause... that message is too vague MS should do better

Wagnerp added a commit that referenced this issue Oct 29, 2023
@Wagnerp
Copy link
Contributor

Wagnerp commented Oct 30, 2023

@giduac & @Smurf-IV

Progress so far...

1009

Toolbars hate images, so using text

@giduac
Copy link
Author

giduac commented Oct 31, 2023

@Wagnerp
Will see if I can spend some more time on it in a week or 2 or 3, to busy atm.

It's not a priority request so... ;)

@Wagnerp
Copy link
Contributor

Wagnerp commented Nov 6, 2023

Hi @giduac

The feature is now in nightly build >= .310

Wagnerp added a commit that referenced this issue Nov 18, 2023
Wagnerp added a commit that referenced this issue Nov 18, 2023
@giduac
Copy link
Author

giduac commented Nov 27, 2023

Hi @Wagnerp

I had a brief look at it.

Can you please elaborate a bit here on the two components KryptonAboutToolkit and KryptonAboutBox.
How these differ from each other and/or are intended.

@Wagnerp
Copy link
Contributor

Wagnerp commented Nov 27, 2023

Hi @Wagnerp

I had a brief look at it.

Can you please elaborate a bit here on the two components KryptonAboutToolkit and KryptonAboutBox. How these differ from each other and/or are intended.

Hi @giduac

Sure, so the KryptonAboutToolkit shows the details about the toolkit, and the KryptonAboutBox shows information about your application, by pulling information from the binary.

I hope this helps.

@giduac
Copy link
Author

giduac commented Nov 27, 2023

Just thought on that and the previous ideas.

How about to combine the information from both dialogs into one. Maybe said better, add the application info as a separate page/button?

And on the previous ideas.
Just use this one form and only add a button to the toolbox window which invokes the dialog.

Altogether that would save a bit of work and still work as a whole?

@Wagnerp
Copy link
Contributor

Wagnerp commented Nov 27, 2023

Just thought on that and the previous ideas.

How about to combine the information from both dialogs into one. Maybe said better, add the application info as a separate page/button?

And on the previous ideas. Just use this one form and only add a button to the toolbox window which invokes the dialog.

Altogether that would save a bit of work and still work as a whole?

Will work on it this week :)

@Wagnerp
Copy link
Contributor

Wagnerp commented Jun 20, 2024

Hi @giduac

Is this still needed?

@giduac
Copy link
Author

giduac commented Jun 20, 2024

Imo to leave this open for later on when there's time left.
An for now turn the already present items off in the Toolbox.

Keep it for a rainy day... :)

@giduac
Copy link
Author

giduac commented Jun 20, 2024

I'll make a pr turning them off for now

@Wagnerp
Copy link
Contributor

Wagnerp commented Jun 20, 2024

I'll make a pr turning them off for now

v100?

@giduac
Copy link
Author

giduac commented Jun 20, 2024

Definitely.

All this stuff can go on the back burner until we have things sorted and well under control.
From there on those can be reviewed, prioritized, planned and further executed.

@Wagnerp Wagnerp removed their assignment Jun 20, 2024
@Wagnerp Wagnerp removed the under investigation This bug/issue is currently under investigation. label Jun 20, 2024
@Wagnerp Wagnerp modified the milestones: Version 90, Version 100 Jun 20, 2024
@Wagnerp
Copy link
Contributor

Wagnerp commented Jun 20, 2024

Definitely.

All this stuff can go on the back burner until we have things sorted and well under control. From there on those can be reviewed, prioritized, planned and further executed.

Trying to be stricter. I think a list needs to be created for what to do for v90.

@giduac
Copy link
Author

giduac commented Jun 20, 2024

Time is at a premium...

Actually we should look actively to attract one or two more persons at least to take the pressure off

@Wagnerp
Copy link
Contributor

Wagnerp commented Jun 20, 2024

Time is at a premium...

Actually we should look actively to attract one or two more persons at least to take the pressure off

Post a message on Discord?

@giduac
Copy link
Author

giduac commented Jun 20, 2024

I'll make a pr turning them off for now

KAboutBox was already hidden from the toolbox

@Wagnerp Wagnerp added the version:100 All things to do with V100. label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress A fix for this issue is in the works. new feature A new feature has been requested. suggestion A suggestion has been requested. version:100 All things to do with V100.
Projects
None yet
3 participants