[Bug]: Cannot add a KryptonPage to a KryptonNavigator

[Wagnerp]

As found in today's nightly build, 142.

[Smurf-IV]

What version of VS is that?
Perhaps "they" are starting to be more restrictive on the framework designer !

[Wagnerp]

What version of VS is that?

Version 17.6.x, happens when using both .NET Framework & .NET

[Smurf-IV]

I have been noticing that when trying to build / run the existing demo apps in the designer, that there are many errors.
I think it is an impact of the partial understanding of the nullable work that is still in progress.
OR, it is an impact of the designer moving forward forcing the rework required to use the new Visual Studio Way Of Working.

[Wagnerp]

I have been noticing that when trying to build / run the existing demo apps in the designer, that there are many errors. I think it is an impact of the partial understanding of the nullable work that is still in progress. OR, it is an impact of the designer moving forward forcing the rework required to use the new Visual Studio Way Of Working.

@Smurf-IV Think I've worked it out... we're not checking for null when certain events are raised #1023 (comment)

[Smurf-IV]

Also found via the fix for Krypton-Suite/Theme-Palettes#51

[Smurf-IV]

It's gonna take a while to sort and fix all these ..

[Wagnerp]

I think @MHartmann-427 said that ReSharper can assist with this #1023 (comment)

[Smurf-IV]

It can, but first you have to modify all the eventhandlers to be nullable....

[MHartmann-427]

No, ReSharper can assist you with this issue out-of-the-box.
Here's a small example:

The blue squiggle comes from ReSharper telling you about possible NullReferenceException.
So you can use menu "ReSharper" => "Inspect" => "Code Issues in Solution" and filter the result to show only "Possible 'System.NullReferenceException'" issue.

[Wagnerp]

Once a few are done (in a file), you can let AI do the rest

[Wagnerp]

@Smurf-IV I've now fixed this, will be in the next PR :)

[Wagnerp]

Please test in latest nightly >= .178

[MHartmann-427]

There are still a lot of nullability issues in the code.
Next crash (again a NullReferenceException) in class "ViewDrawMenuItem", method "ShowSubMenu".

Here's the stack trace:
bei Krypton.Toolkit.ViewDrawMenuItem.ShowSubMenu(Boolean keyboardActivated)
bei Krypton.Toolkit.MenuItemController.ShowSubMenu()
bei Krypton.Toolkit.ViewContextMenuManager.OnDelayTimerExpire(Object sender, EventArgs e)
bei System.Windows.Forms.Timer.OnTick(EventArgs e)
bei System.Windows.Forms.Timer.TimerNativeWindow.WndProc(Message& m)
bei System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Can't tell you which object is NULL and causes this exception, sorry.

I think the alpha branch is far, far away from being testable because of all those nullability issues. I still can't understand, why all the nullability checks that exist in version 70 are removed in version 80.

[Wagnerp]

I still can't understand, why all the nullability checks that exist in version 70 are removed in version 80.

I think it was something to do with introducing nullables. I'll be away on holiday until Tuesday, so can't do anymore work until then.

[Wagnerp]

Might need more work to be done on this

[Wagnerp]

There are still a lot of nullability issues in the code.
Next crash (again a NullReferenceException) in class "ViewDrawMenuItem", method "ShowSubMenu".

Here's the stack trace:
bei Krypton.Toolkit.ViewDrawMenuItem.ShowSubMenu(Boolean keyboardActivated)
bei Krypton.Toolkit.MenuItemController.ShowSubMenu()
bei Krypton.Toolkit.ViewContextMenuManager.OnDelayTimerExpire(Object sender, EventArgs e)
bei System.Windows.Forms.Timer.OnTick(EventArgs e)
bei System.Windows.Forms.Timer.TimerNativeWindow.WndProc(Message& m)
bei System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Can't tell you which object is NULL and causes this exception, sorry.

I think the alpha branch is far, far away from being testable because of all those nullability issues. I still can't understand, why all the nullability checks that exist in version 70 are removed in version 80.

Duplicate of #1034

[Smurf-IV]

It's gonna take a while to sort and fix all these ..

[Smurf-IV]

I'll start to work on this bug (And others I have found during the investigation) when PtIV(#1046) has been merged (It'll probably be next weekend now)

[Smurf-IV]

Build after PtIV merge appears to work (May have been fixed earlier, but this is what the following video is from)
Taken with Current alpha (After PtIV merge) in Visual Studio 17.7.P3