Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: KryptonPropertyGrid background colour/text don't display correctly for some (most) themes #1108

Closed
Wagnerp opened this issue Aug 27, 2023 · 5 comments
Closed

[Bug]: KryptonPropertyGrid background colour/text don't display correctly for some (most) themes #1108

Wagnerp opened this issue Aug 27, 2023 · 5 comments
Labels
bug Something isn't working completed This issue has been completed.

Comments

@Wagnerp
Copy link
Contributor

Wagnerp commented Aug 27, 2023

The KryptonPropertyGrid background colour/text don't display correctly in black (dark modes)

263517148-fd846564-f893-4c55-84df-47894e396a67
@Wagnerp Wagnerp added bug Something isn't working area:themes All things to do with themes. labels Aug 27, 2023
@Smurf-IV Smurf-IV changed the title [Bug]: KryptonPropertyGrid background colour/text don't display correctly in black (dark modes) [Bug]: KryptonPropertyGrid background colour/text don't display correctly for some (most) themes Aug 28, 2023
@Smurf-IV Smurf-IV removed the area:themes All things to do with themes. label Aug 28, 2023
@Smurf-IV
Copy link
Member

BUT:
Using the PropertyGrid example, the above is unproduceable ??
image

Then switch to silver:
image

Smurf-IV added a commit that referenced this issue Aug 28, 2023
@Smurf-IV
- Things found whilst investigating attached items
0c7a6e5 
#335
#1108
@Smurf-IV Smurf-IV mentioned this issue Aug 28, 2023
Merged
@Wagnerp
Copy link
Contributor Author

Wagnerp commented Aug 28, 2023

@Smurf-IV Do we know what palette colour entry the text is using?

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Aug 28, 2023 •
edited

Wait... why is the text using the ButtonText and not the LabelText entry (same with KComboBoxes)?

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Aug 28, 2023

Ok, I found out why, the text is using the TextButtonNormal. We can't use white button text in O2k7 themes due to the glossy background. The solution is to use TextLabelControl for the text colour. Hope this makes sense?

@Smurf-IV
Copy link
Member

Smurf-IV commented Sep 3, 2023

The "Colours" are coming from
_stateCommon = new PaletteInputControlTripleRedirect(_paletteRedirect, PaletteBackStyle.InputControlStandalone, PaletteBorderStyle.InputControlStandalone, PaletteContentStyle.InputControlStandalone, null);

I'll check what PaletteBackStyle.InputControlStandalone can be replaced with to give TextLabelControl equivalent(s)

@Smurf-IV Smurf-IV self-assigned this Sep 3, 2023
@Smurf-IV Smurf-IV added the in progress A fix for this issue is in the works. label Sep 3, 2023
Smurf-IV added a commit that referenced this issue Sep 3, 2023
@Smurf-IV
- Attempt fix to the colour usages for the "PropertyGrid"
0f083ee 
- use `_stateCommon = new PaletteInputControlTripleRedirect(_paletteRedirect, PaletteBackStyle.InputControlStandalone, PaletteBorderStyle.HeaderCalendar, PaletteContentStyle.LabelNormalPanel, null);
`
- Some more tinkering with the nullables etc.

#1108
@Smurf-IV Smurf-IV removed their assignment Sep 3, 2023
@Smurf-IV Smurf-IV added completed This issue has been completed. and removed in progress A fix for this issue is in the works. labels Sep 3, 2023
@Smurf-IV Smurf-IV mentioned this issue Sep 3, 2023
Merged
@Smurf-IV Smurf-IV closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working completed This issue has been completed.
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

alpha-1108-KPropertyGridColours Krypton-Suite/Standard-Toolkit
2 participants
@Wagnerp @Smurf-IV