Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Rounding should use float or double instead of int #197

Closed
Wagnerp opened this issue Jul 17, 2021 · 3 comments
Closed

[Feature Request]: Rounding should use float or double instead of int #197

Wagnerp opened this issue Jul 17, 2021 · 3 comments
Labels
completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Milestone
November 2021 (Ve...

Comments

@Wagnerp
Copy link
Contributor

Wagnerp commented Jul 17, 2021

The Rounding should use float or double instead of int

Why? By using float or double, it allows for finer control, i.e. 0, 0.1 ... 0.9 - 1.0 etc. With int you're stuck with using 'whole' numbers.
@Wagnerp Wagnerp added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. labels Jul 17, 2021
@Wagnerp Wagnerp self-assigned this Jul 17, 2021
@Smurf-IV
Copy link
Member

Also check that individual controls can have different rounding values from the GlobalValue

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 18, 2021

Also check that individual controls can have different rounding values from the GlobalValue

Will do, may separate textboxes from buttons etc.

@Wagnerp Wagnerp added in progress A fix for this issue is in the works. under investigation This bug/issue is currently under investigation. labels Jul 18, 2021
Wagnerp added a commit that referenced this issue Jul 18, 2021
@Wagnerp
* Implement #197
2c0322f
@Wagnerp Wagnerp mentioned this issue Jul 18, 2021
Merged
@Wagnerp Wagnerp removed their assignment Aug 1, 2021
@Wagnerp Wagnerp added completed This issue has been completed. and removed in progress A fix for this issue is in the works. under investigation This bug/issue is currently under investigation. labels Aug 1, 2021
@Wagnerp
Copy link
Contributor Author

Wagnerp commented Aug 1, 2021

Available in build 2108 August update (Canary)

@Wagnerp Wagnerp closed this as completed Aug 1, 2021
@Wagnerp Wagnerp added this to the November 2021 (Version 6) milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Projects
None yet
Milestone
November 2021 (Version 6)
Development

No branches or pull requests
2 participants
@Wagnerp @Smurf-IV