Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: 'DarkMode' for KryptonRichTextBox/KryptonTextBox #207

Closed
Wagnerp opened this issue Jul 25, 2021 · 24 comments
Closed

[Feature Request]: 'DarkMode' for KryptonRichTextBox/KryptonTextBox #207

Wagnerp opened this issue Jul 25, 2021 · 24 comments
Labels
area:themes All things to do with themes. completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.

Comments

@Wagnerp
Copy link
Contributor

Wagnerp commented Jul 25, 2021

Is your feature request related to a problem? Please describe.
Something like this:

image

(The page background/forecolour)

@Wagnerp Wagnerp added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. under investigation This bug/issue is currently under investigation. labels Jul 25, 2021
@Wagnerp Wagnerp added this to the November 2021 (Version 6) milestone Jul 25, 2021
@Wagnerp Wagnerp self-assigned this Jul 25, 2021
@Smurf-IV
Copy link
Member

Smurf-IV commented Jul 25, 2021

This will ned to be extended to any edit entry,
ComboBox, NumericUpDowner, WebBrowser / etc.

It should be in the Theme, and I do not understand why the dark themes enforce the white background.
The sparkle Blue I think is the only one that attempts to make them darker (And does a good job)

So the Dark themes, should have the Dark Backgrounds

So I think this should be a Bug against the Dark themes !

@Smurf-IV Smurf-IV added the area:themes All things to do with themes. label Jul 25, 2021
Wagnerp added a commit that referenced this issue Jul 25, 2021
@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 25, 2021

This will ned to be extended to any edit entry,
ComboBox, NumericUpDowner, WebBrowser / etc.

It should be in the Theme, and I do not understand why the dark themes enforce the white background.
The sparkle Blue I think is the only one that attempts to make them darker (And does a good job)

So the Dark themes, should have the Dark Backgrounds

So I think this should be a Bug against the Dark themes !

I agree, ATM I've made it optional

@Smurf-IV
Copy link
Member

Lets fix the themes and not introduce Yet Another Optional thing that will become mute when the proper fix is done.

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 25, 2021

One theme that might be good to do in the future is the 'Cobalt' theme

image

@Smurf-IV
Copy link
Member

Add that to the "Visual Studio Themes" request that already exists
(Ant Idea what font to use for that?)

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 25, 2021

Add that to the "Visual Studio Themes" request that already exists
(Ant Idea what font to use for that?)

I use Cascadia Code https://github.com/microsoft/cascadia-code

@Smurf-IV
Copy link
Member

Yes, but that is not going to be applicable to a theme :-(

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 25, 2021

@Smurf-IV Are the back colours controlled by InputControlBackNormal?

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 25, 2021

Ok, I think I can implement it on a theme level, but what should the blue themes be?

@Smurf-IV
Copy link
Member

Ok, I think I can implement it on a theme level, but what should the blue themes be?

Leave them as they are, or just use a vary pale "cream?" hint over the white.
This -I think- is normal for Blue themes to have white edit areas.

Or,
Have new Blue themes called 2021 which have a better tint for the edit areas, (More Studio blue theme style - which has a definite colour difference from white
image

Wagnerp added a commit that referenced this issue Jul 25, 2021
@Smurf-IV
Copy link
Member

@Smurf-IV Are the back colours controlled by InputControlBackNormal?

Looks like it, Not sure if these are applied to RTF and Browser tho, and I also do not know which is used by default:
image

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 25, 2021

Ok, I think I can implement it on a theme level, but what should the blue themes be?

Leave them as they are, or just use a vary pale "cream?" hint over the white.
This -I think- is normal for Blue themes to have white edit areas.

Or,
Have new Blue themes called 2021 which have a better tint for the edit areas, (More Studio blue theme style - which has a definite colour difference from white
image

Ok, checked in some 'black' theme changes, would you mind taking them for a test drive?

@Smurf-IV
Copy link
Member

Ok, checked in some 'black' theme changes, would you mind taking them for a test drive?

That'll have to wait, I'm pulling the Palette code apart, and also fixing more Warnings and messages.

I'll do the test after I create a PR for the changes mentioned.. So add more changes to the other themes if you like.

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 25, 2021

Useful for the VS themes https://docs.microsoft.com/en-us/visualstudio/extensibility/ux-guidelines/color-value-reference-for-visual-studio?view=vs-2019

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 25, 2021

I know that this might be a long shot, but do we know where we can find the radio button icons for MS Office?

@Smurf-IV
Copy link
Member

That'll be version dependent, and they may be hidden in a resource MEF style dll
Could be C++ for the older versions, so probably be able to get them via a dll load into visual Studio.

BUT, They might draw them manually..

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jul 25, 2021

That'll be version dependent, and they may be hidden in a resource MEF style dll
Could be C++ for the older versions, so probably be able to get them via a dll load into visual Studio.

BUT, They might draw them manually..

I wonder how Phil extracted these

RB2007Blue

As it could open up adding support for the other colours

@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 3, 2021

Is this done with the Canary Dark / Light themes ?
Or is it that the Boxes do not use the colours anyway ?

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Aug 3, 2021

Is this done with the Canary Dark / Light themes ?
Or is it that the Boxes do not use the colours anyway ?

No, it appears that the images are one kind

@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 3, 2021

What is set in the Sparkle themes to make them go darker then ?

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Aug 3, 2021

What is set in the Sparkle themes to make them go darker then ?

These:

RBSparkleTC
RBSparkleD
RBSparkleDC
RBSparkleN
RBSparkleNC
RBSparkleOrangeNC
RBSparkleOrangeP
RBSparkleOrangePC
RBSparkleOrangeT
RBSparkleOrangeTC
RBSparkleP
RBSparklePC
RBSparklePurpleNC
RBSparklePurpleP
RBSparklePurplePC
RBSparklePurpleT
RBSparklePurpleTC
RBSparkleT

@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 3, 2021

And it is mentioned as fixed in Canary:
image

@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 3, 2021

What is set in the Sparkle themes to make them go darker then ?

These:

RBSparkleTC
RBSparkleD
RBSparkleDC
RBSparkleN
RBSparkleNC
RBSparkleOrangeNC
RBSparkleOrangeP
RBSparkleOrangePC
RBSparkleOrangeT
RBSparkleOrangeTC
RBSparkleP
RBSparklePC
RBSparklePurpleNC
RBSparklePurpleP
RBSparklePurplePC
RBSparklePurpleT
RBSparklePurpleTC
RBSparkleT

They are radio buttons, not the ####TextBox mentioned in the Title.
Should really create a new Issue for those.

@Wagnerp Wagnerp removed their assignment Aug 20, 2021
@Wagnerp Wagnerp added completed This issue has been completed. and removed under investigation This bug/issue is currently under investigation. in progress A fix for this issue is in the works. labels Aug 20, 2021
@Wagnerp Wagnerp closed this as completed Aug 20, 2021
@Wagnerp Wagnerp pinned this issue Aug 20, 2021
@Wagnerp
Copy link
Contributor Author

Wagnerp commented Aug 20, 2021

Pinning, due to useful resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:themes All things to do with themes. completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Projects
None yet
Development

No branches or pull requests

2 participants