Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Font Dialog is in the Main Forms elements - Where is Kryptons' Standard themed equivalent #243

Closed
Smurf-IV opened this issue Aug 6, 2021 · 17 comments
Labels
completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.

Comments

@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 6, 2021

e.g. Dark theme:
image

@Smurf-IV Smurf-IV added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. labels Aug 6, 2021
@Smurf-IV Smurf-IV changed the title [Feature Request]: Font Dialog (And others) are in the Main Forms elements - Wheres Kryptons Standard themed equivalent [Feature Request]: Font Dialog (And others) are in the Main Forms elements - Where are Kryptons' Standard themed equivalent Aug 6, 2021
@Smurf-IV
Copy link
Member Author

Smurf-IV commented Aug 8, 2021

It might be a case of just deriving from the Winform, Catching the OnLoad, setting colours of elements, and then display..

Rather than trying to re-create the full path of code:
https://referencesource.microsoft.com/#system.windows.forms/winforms/Managed/System/WinForms/FontDialog.cs

Or using outdated interops to get to the base OS classes.

@Wagnerp
Copy link
Contributor

Wagnerp commented Aug 9, 2021

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Aug 9, 2021

This could help

https://www.codeproject.com/Articles/10706/Font-ListBox-and-ComboBox-Controls-with-Top-5-Favo

That would be a nice addition to the Extended ComboBox / List projects.
And
His other project would be nice as well:
https://www.codeproject.com/Articles/10688/BevelLine-Control-with-Designer-Selection-Rules
With the Standard Theme overrides applied ;-)

@Smurf-IV
Copy link
Member Author

Getting there..
What I am trying to do is something similar to the Delphi VCL Theming (No idea how they do the magic - but they do not redesign a form to "Look" like a control [Like they do in mono - which is another option])
So the idea is

  • to keep the native control native
  • Override their drawing via the re-use of Krypton drawing elements
  • Make this code generic so that it can be applied to all "OS Common Dialogs"

The following picture shows

  • Test App in VS Designer
  • App running and Office 2010 - Black selected
  • "Kryptonised" FontDialog with the background and the Colour: label converted
  • All control positions and text taken from the control.
    image

@Wagnerp
Copy link
Contributor

Wagnerp commented Aug 10, 2021

Can something similar be done for file dialogs?

@Smurf-IV
Copy link
Member Author

Yes, What I am aiming for is anything that is derived from the CommonDialog base class wrapper

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Aug 11, 2021

Another update to generic overloading

  • Managed to improve the background colour replacement (See around the buttons)
  • Group and label fonts are changed (Its really subtle, but they are closer to the controls)
  • All Label colours are changed (Not Groups yet !)
    image

@Smurf-IV
Copy link
Member Author

And tonights offering is:
image

Button replacement !

@Smurf-IV
Copy link
Member Author

I think I should leave the List / Combo Drop Boxes alone, as it just makes scrolling messy, and the background for the actual items is not replaced either !
Right - Next is the CheckBoxes

@Smurf-IV
Copy link
Member Author

Done Check Boxes:
image

@Smurf-IV
Copy link
Member Author

Removed the Drawing blips around the buttons:
image

@Smurf-IV
Copy link
Member Author

Erm.. Done:
image

BUT,
Now need to extract the code into a utility class, so that it can be applied to the other Common Dialogs

@Smurf-IV
Copy link
Member Author

Oh, and also to wrap the control in a KryptonForm as a toolbox ;-)
image

@Wagnerp
Copy link
Contributor

Wagnerp commented Aug 13, 2021

Is it going to be possible to use the breadcrumb control for file dialogs?

Still testing the new inputbox :)

@Smurf-IV
Copy link
Member Author

Is it going to be possible to use the breadcrumb control for file dialogs?

Not sure that will be a wise thing to do, as it entails lot's of linkage out to an existing control(s), so probably not.

Smurf-IV added a commit that referenced this issue Aug 13, 2021
- Only replace buttons (Normal and checkbox)
- Replace drawing of GroupBox's
- Everything else is handled "in place"
- Some code tidys as well
 #243
@Smurf-IV Smurf-IV changed the title [Feature Request]: Font Dialog (And others) are in the Main Forms elements - Where are Kryptons' Standard themed equivalent [Feature Request]: Font Dialog is in the Main Forms elements - Where is Kryptons' Standard themed equivalent Aug 13, 2021
@Smurf-IV
Copy link
Member Author

Done:
image

@Smurf-IV Smurf-IV added completed This issue has been completed. and removed under investigation This bug/issue is currently under investigation. labels Aug 14, 2021
@Smurf-IV Smurf-IV added this to the November 2021 (Version 6) milestone Aug 14, 2021
@Smurf-IV
Copy link
Member Author

image

@Smurf-IV Smurf-IV removed their assignment Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Projects
None yet
Development

No branches or pull requests

2 participants