Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Panel AntiAlias Border Problem #308

Closed
sdreb3421 opened this issue Aug 30, 2021 · 19 comments
Closed

[Bug]: Panel AntiAlias Border Problem #308

sdreb3421 opened this issue Aug 30, 2021 · 19 comments
Labels
bug Something isn't working fixed This issue has been fixed.

Comments

@sdreb3421
Copy link

Gray border lines are being drawn on the top/left when setting the GraphicsHint to AntiAlias on a KryptonPanel. This also shows up on the inner panel of a KryptonGroup with AntiAlias back, but only when the group is disabled. The image below shows an example of the weird lines for a KryptonGroup (left) and KryptonPanel (right).

image

To reproduce, add a KryptonPanel to a form. Set the GraphicsHint of the panel to be AntiAlias. Set the back color of the form and panel to be Black (not necessary but helps illuminate the issue).

Tested on both FrameWork and NET5 using 6.0.2108.1 as well as previous stable versions.

@sdreb3421 sdreb3421 added the bug Something isn't working label Aug 30, 2021
@sdreb3421 sdreb3421 changed the title [Bug]: Panel AntiAlias Propblem [Bug]: Panel AntiAlias Border Problem Aug 30, 2021
@Smurf-IV Smurf-IV self-assigned this Aug 31, 2021
@Smurf-IV Smurf-IV added the under investigation This bug/issue is currently under investigation. label Aug 31, 2021
@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 31, 2021

It's much worse than that..
Take the following (KryptonForm with Full Dock Default KryptonPanel, then with 2 KPanels set to Black and AntiAlias)
image

And the use the "OS magnifier app" on the screen, and it will be seen that the left and top borders are grey with corner rounding !

With AntiAlias off, then they are solid square boxes

@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 31, 2021

@sdreb3421 I'm confused with the pictures that you have shown..

Is the left a KryptonGroupBox (With rounding), set to black, and then the internal panel also set to black, but only the internal panel disabled ?

Or a KryptonGroup (With rounding) .. etc. ?

Or is it a KPanel with rounding ?

This is what I get when the "Panels" are KryptonGroupBoxes:
image

@Smurf-IV
Copy link
Member

Please check the (Draft PR above) projects I have modified to see if I have replicated as you have explained

@sdreb3421
Copy link
Author

The left image is a KryptonGroup with rounding and the StateCommon back set to black and AntiAlias. The inner panel properties are left default. The lines will only show up if it is originally enabled then disabled at runtime. I didn't explain in too much detail because I figured the KryptonPanel was the root cause.

@sdreb3421
Copy link
Author

@Smurf-IV I've never looked at a PR before. I can see the files you've changed, but can't easily see if you've replicated it appropriately. Can I open the PR up in Visual Studio somehow?

@Smurf-IV
Copy link
Member

Smurf-IV commented Sep 3, 2021

Download (Select) the branch to your machine
Then open as normal in visual studio.

@Smurf-IV
Copy link
Member

Smurf-IV commented Sep 3, 2021

image

@sdreb3421
Copy link
Author

I was unsuccessful. We use Azure DevOps for our repos so I'm unfamiliar with the Git system. I connected to the Standard-Toolkit-Demos solution but it has tons of build errors so I can't open any of the forms. It looks like the projects aren't seeing the Krypton dlls/nuget. Should I add the canary nuget to all these projects?

@Smurf-IV
Copy link
Member

Smurf-IV commented Sep 5, 2021

Just open the nuget solution.
image

@Smurf-IV Smurf-IV added the help wanted Extra attention is needed label Sep 14, 2021
@Smurf-IV Smurf-IV removed the under investigation This bug/issue is currently under investigation. label Oct 17, 2021
@Smurf-IV Smurf-IV removed their assignment Oct 17, 2021
@Smurf-IV
Copy link
Member

@sdreb3421
Can this be closed now, that the demo code is showing that it is functioning as expected ?

@sdreb3421
Copy link
Author

We're you able to reproduce and fix the issue? I stopped using Krypton panels and groups as a workaround. Would there still be benefit to downloading the PR and verifying?

@Smurf-IV
Copy link
Member

No I was not able to reproduce as per description.
And yes it would be good to see if the Demo App I created displays the same issue(s) that you saw on your machine, and then allow you to alter it if does not cause problem you describe to replicate it..

@Smurf-IV Smurf-IV added awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. and removed help wanted Extra attention is needed labels Feb 13, 2022
@Smurf-IV
Copy link
Member

@sdreb3421 Can this be closed now ?

@sdreb3421
Copy link
Author

I just made a commit to the code you provided. I added a button to the ColouredForm to enable/disable the groupbox and show the issue. Can you confirm on your end?

@sdreb3421
Copy link
Author

@Smurf-IV just following up on issues I've opened tonight...

@Smurf-IV
Copy link
Member

@Smurf-IV just following up on issues I've opened tonight...

I missed the update you made, thanks for pointing it out, I'll have a look next week earliest.

@Smurf-IV Smurf-IV self-assigned this May 31, 2022
@Smurf-IV Smurf-IV added under investigation This bug/issue is currently under investigation. and removed awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. labels May 31, 2022
@Smurf-IV
Copy link
Member

Smurf-IV commented Jun 9, 2022

I just made a commit to the code you provided. I added a button to the ColouredForm to enable/disable the groupbox and show the issue. Can you confirm on your end?

Github does not show your commit getting into the PR, either via a new update to this item, or directly into the PR:
image

@Smurf-IV
Copy link
Member

Smurf-IV commented Jun 9, 2022

Latest code uses just panels (Not KGroups) and demonstrates anti-alias lines (Disabled or not):
image

@sdreb3421
Copy link
Author

Sorry, apparently I do not know how to use git. That looks like what I'm seeing.

Smurf-IV added a commit that referenced this issue Jun 9, 2022
- Add the other Grpahics drawing types

#308
@Smurf-IV Smurf-IV closed this as completed Jun 9, 2022
@Smurf-IV Smurf-IV added fixed This issue has been fixed. and removed under investigation This bug/issue is currently under investigation. labels Jun 9, 2022
@Smurf-IV Smurf-IV removed their assignment Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed This issue has been fixed.
Projects
None yet
Development

No branches or pull requests

2 participants